Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Logitech feature Illumination #30

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add Logitech feature Illumination #30

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/tools/hidpp-list-features.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,8 +69,10 @@ static const std::map<uint16_t, const char *> HIDPP20Features = {
{ 0x1bc0, "Persistent remappable action" },
{ 0x1d4b, "Wireless device status" },
{ 0x1e00, "Enable hidden features" },
//{ 0x1eb0, "Seen on Logitech Litra Glow" },
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1EB0 is also used in a number of other devices, like a mouse from 2015, another mouse, etc.
Short of knowing what it is, I don't see a reason to add it to the list.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's an internal generic test/development feature that's not useful to users and won't be publicly documented. Devices do different things with that feature and it's not specific to the Litra Glow.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't the documentation, that it IS a test feature a good reason to add it to the list - even only as a comment?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd say that depends on the purpose of the list. It seems it mostly lists features that showed up in public documentation. But one could obviously shoot for completeness, in which case { 0x1eb0, "Internal test feature" } would be an entirely reasonable entry. 😄

{ 0x1f1f, "Firmware Properties" },
{ 0x1f20, "ADC Measurement" },
{ 0x1990, "Illumination Light" },
{ 0x2001, "Left right swap" },
{ 0x2005, "Swap button" },
{ 0x2006, "Pointer Axes Orientation" },
Expand Down