Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove REPO_ prefix from repo type enum #11

Merged
merged 1 commit into from
Feb 13, 2024
Merged

Remove REPO_ prefix from repo type enum #11

merged 1 commit into from
Feb 13, 2024

Conversation

ccampo133
Copy link
Contributor

@ccampo133 ccampo133 commented Feb 13, 2024 •
edited
Loading

Description of the change

This makes it easier to parse on the backend (see: https://github.com/cyralinc/dmap-backend/pull/87)

Type of change

  • Bug fix (non-breaking change that fixes an issue).
  • New feature (non-breaking change that adds functionality).
  • Breaking change (fix or feature that would cause existing functionality to not work as expected).

Checklists

Development

  • Lint rules pass locally.
  • The code changed/added as part of this pull request has been covered with tests.
  • All tests related to the changed code pass.

Code review

  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached.
  • Jira issue referenced in commit message and/or PR title.

Testing

Unit tests.

@ccampo133 ccampo133 merged commit 5d10f77 into main Feb 13, 2024
1 check passed
ricardorey10
ricardorey10 approved these changes Feb 13, 2024
View reviewed changes
scan/scanner.go
RepoTypeRedshift RepoType = "REPO_TYPE_REDSHIFT"
RepoTypeDynamoDB RepoType = "REPO_TYPE_DYNAMODB"
RepoTypeS3 RepoType = "REPO_TYPE_S3"
RepoTypeRDS RepoType = "TYPE_RDS"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we really need the TYPE_ prefix as well? I guess we could also get rid of it.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's necessary to match the protobuf representation, so we can pull it from a map. See https://github.com/cyralinc/dmap-backend/pull/87/files

@ccampo133 ccampo133 deleted the rename_repotype branch February 13, 2024 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yoursnerdly yoursnerdly yoursnerdly approved these changes

@ricardorey10 ricardorey10 ricardorey10 approved these changes

@VictorGFM VictorGFM Awaiting requested review from VictorGFM

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ccampo133 @ricardorey10 @yoursnerdly