Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove REPO_ prefix from repo type enum #11

Merged
merged 1 commit into from
Feb 13, 2024
Merged

Remove REPO_ prefix from repo type enum #11

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions scan/scanner.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,10 +20,10 @@ type RepoType string

const (
// Repo types
RepoTypeRDS RepoType = "REPO_TYPE_RDS"
RepoTypeRedshift RepoType = "REPO_TYPE_REDSHIFT"
RepoTypeDynamoDB RepoType = "REPO_TYPE_DYNAMODB"
RepoTypeS3 RepoType = "REPO_TYPE_S3"
RepoTypeRDS RepoType = "TYPE_RDS"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we really need the TYPE_ prefix as well? I guess we could also get rid of it.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's necessary to match the protobuf representation, so we can pull it from a map. See https://github.com/cyralinc/dmap-backend/pull/87/files

RepoTypeRedshift RepoType = "TYPE_REDSHIFT"
RepoTypeDynamoDB RepoType = "TYPE_DYNAMODB"
RepoTypeS3 RepoType = "TYPE_S3"
)

// Repository represents a scanned data repository.
Expand Down
Loading