Add "documentFormat" option #137
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In a similar way to dateFormat/binaryFormat, this allows the user to specify the type of returned documents via the documentFormat option. Passing 'array' will mean documents are returned as native arrays, otherwise documents will continue to be returned as ArrayObject's.
|
Changes in ed8368d are unrelated but fixes styling errors causing the build to fail |
| $native = new \ArrayObject(); | ||
| if (isset($opts['documentFormat']) && $opts['documentFormat'] == 'array') { | ||
| $native = array(); | ||
| } else { |
There was a problem hiding this comment.
I'd prefer an explicit set of allowed values. How about?
documentFormatnot set at alldocumentFormat == 'array'documentFormat == 'object'
So the else branch should verify that documentFormat is either not isset, or that its value is 'object'. Otherwise it should throw a RqlDriverError.
Does that sound reasonable to you?
|
Thanks for the pull request @thomseddon ! I added one comment, but otherwise this looks good to me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In a similar way to
dateFormat/binaryFormat, this allows the user to specify the type of returned documents via thedocumentFormatoption.Passing 'array' will mean documents are returned as native arrays, otherwise documents will continue to be returned as
ArrayObject's.