Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

retain label for data frames #2019

Merged
merged 1 commit into from
Oct 3, 2024
Merged

retain label for data frames #2019

merged 1 commit into from
Oct 3, 2024

Conversation

ddsjoberg
Copy link
Owner

What changes are proposed in this pull request?
<< Insert text here that can be directly copied into NEWS.md by your reviewer. >>

If there is an GitHub issue associated with this pull request, please provide link.
closes #2017

Reviewer Checklist (if item does not apply, mark is as complete)

  • PR branch has pulled the most recent updates from main branch.
  • If a bug was fixed, a unit test was added.
  • Run pkgdown::build_site(). Check the R console for errors, and review the rendered website.
  • Code coverage is suitable for any new functions/features: devtools::test_coverage()
  • usethis::use_spell_check() runs with no spelling errors in documentation
  • All GitHub Action workflows pass with a ✅

When the branch is ready to be merged into master:

  • Update NEWS.md with the changes from this pull request under the heading "# gtsummary (development version)". If there is an issue associated with the pull request, reference it in parentheses at the end update (see NEWS.md for examples).
  • Increment the version number using usethis::use_version(which = "dev")
  • Run usethis::use_spell_check() again
  • Approve Pull Request
  • Merge the PR. Please use "Squash and merge".

@ddsjoberg ddsjoberg merged commit 928e43a into main Oct 3, 2024
7 checks passed
@ddsjoberg ddsjoberg deleted the 2017-label-drop-for-data.frames branch October 3, 2024 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug Report: Labels are lost in tbl_summary when the variable used in by= contains missing values
1 participant
@ddsjoberg