Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WALL] george / WALL-5105 / Remove the jurisdiction information on compare account table for wallets #17441

Conversation

heorhi-deriv
Copy link
Contributor

Changes:

  • remove the jurisdiction information on compare account table for wallets

Screenshots:

Real: Desktop/Tablet/Mobile
Screenshot 2024-11-06 at 17 01 14
Screenshot 2024-11-06 at 17 01 44
Screenshot 2024-11-06 at 17 01 54

Demo: Desktop/Tablet/Mobile
Screenshot 2024-11-06 at 17 02 53
Screenshot 2024-11-06 at 17 03 15
Screenshot 2024-11-06 at 17 03 23

Copy link

vercel bot commented Nov 6, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
deriv-app ✅ Ready (Inspect) Visit Preview Nov 13, 2024 0:10am

Copy link
Contributor

github-actions bot commented Nov 6, 2024

A production App ID was automatically generated for this PR. (log)

Click here to copy & paste above information.
- **PR**: [https://github.com/deriv-com/deriv-app/pull/17441](https://github.com/deriv-com/deriv-app/pull/17441)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-heorhi-deriv-coj-1424-remove-the-juri-0d5339.binary.sx?qa_server=red.derivws.com&app_id=24061
    - **Original**: https://deriv-app-git-fork-heorhi-deriv-coj-1424-remove-the-juri-0d5339.binary.sx
- **App ID**: `24061`

Copy link
Contributor

github-actions bot commented Nov 6, 2024

🚨 Lighthouse report for the changes in this PR:

Category Score
🔺 Performance 28
🟧 Accessibility 70
🟢 Best practices 92
🟧 SEO 77
🟧 PWA 78

Lighthouse ran with https://deriv-app-git-fork-heorhi-deriv-coj-1424-remove-the-juri-0d5339.binary.sx/

@heorhi-deriv heorhi-deriv force-pushed the COJ-1424-Remove-the-jurisdiction-information-on-compare-account-table-for-wallets branch from 09b524f to b7942cb Compare November 6, 2024 14:18
@heorhi-deriv heorhi-deriv changed the title [COJ] georeg / COJ-1424 / Remove the jurisdiction information on compare account table for wallets [WALL] george / WALL-5105 / Remove the jurisdiction information on compare account table for wallets Nov 6, 2024
@coveralls
Copy link

coveralls commented Nov 6, 2024

Pull Request Test Coverage Report for Build 11816603404

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 2 (0.0%) changed or added relevant lines in 1 file are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.07%) to 53.154%

Changes Missing Coverage Covered Lines Changed/Added Lines %
packages/wallets/src/features/cfd/screens/CompareAccounts/compareAccountsConfig.ts 0 2 0.0%
Files with Coverage Reduction New Missed Lines %
packages/wallets/src/features/cfd/screens/CompareAccounts/compareAccountsConfig.ts 2 77.65%
Totals Coverage Status
Change from base Build 11815863240: -0.07%
Covered Lines: 32697
Relevant Lines: 57370

💛 - Coveralls

…-information-on-compare-account-table-for-wallets
jim-deriv
jim-deriv previously approved these changes Nov 11, 2024
…-information-on-compare-account-table-for-wallets
nijil-deriv
nijil-deriv previously approved these changes Nov 13, 2024
Copy link
Contributor

Generating Lighthouse report...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants