Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: allow workspaces to be attempted to be deleted when experiments had existed historically [CM-412] #10050

Open
wants to merge 13 commits into
base: main
Choose a base branch
from

delete projects from workspace before deleting the workspace

f741612
Select commit
Loading
Failed to load commit list.
Open

fix: allow workspaces to be attempted to be deleted when experiments had existed historically [CM-412] #10050

delete projects from workspace before deleting the workspace
f741612
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Oct 26, 2024 in 0s

54.82% (+0.21%) compared to dadf75e

View this Pull Request on Codecov

54.82% (+0.21%) compared to dadf75e

Details

Codecov Report

Attention: Patch coverage is 89.47368% with 2 lines in your changes missing coverage. Please review.

Project coverage is 54.82%. Comparing base (dadf75e) to head (f741612).
Report is 70 commits behind head on main.

Files with missing lines Patch % Lines
master/internal/api_workspace.go 89.47% 2 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #10050      +/-   ##
==========================================
+ Coverage   54.60%   54.82%   +0.21%     
==========================================
  Files        1260      840     -420     
  Lines      157635    83102   -74533     
  Branches     3632        0    -3632     
==========================================
- Hits        86082    45563   -40519     
+ Misses      71419    37539   -33880     
+ Partials      134        0     -134
Files with missing lines Coverage Δ
master/internal/api_workspace.go 66.89% <89.47%> (+0.82%) ⬆️

... and 424 files with indirect coverage changes

View more details on Codecov