upgrade xhtml2pdf #21559
upgrade xhtml2pdf #21559
Conversation
|
@calellowitz @emord Is this something that's easy to test after deploy? |
|
I think that you'll need to run the make file to actually update the requirements |
|
yeah. should be easy to test on india |
nickpell
force-pushed
the
np/upgrade-xhtml2pdf
branch
from
e0ec80e
to
74d4788
Compare
woops, fixed |
Cool - I just tested downloading the generated pdf from india. My plan is to merge this branch, deploy, test, and then give the go-ahead to merge to NIC. |
| @@ -13,6 +13,7 @@ alembic==0.8.6 | |||
| amqp==1.4.9 | |||
| anyjson==0.3.3 | |||
| appdirs==1.4.3 | |||
| appnope==0.1.0 # via ipython | |||
There was a problem hiding this comment.
confused by this line. #21563
not sure if it's necessary?
There was a problem hiding this comment.
"The Internet" says that appnope is a dependency of ipython on OSX, but not Linux. Probably #21563 was generated in a Linux environment?
There was a problem hiding this comment.
There was a problem hiding this comment.
This also changes prod-requirements.txt. Since our servers run linux, I think I'd default to whatever is generated.
With that said, from the linked ticket, it doesn't seem like there's a way to enforce this consistently. I'll create an issue and ping danny on it, to see if he knows more after he gets back from offline time
| @@ -13,6 +13,7 @@ alembic==0.8.6 | |||
| amqp==1.4.9 | |||
| anyjson==0.3.3 | |||
| appdirs==1.4.3 | |||
| appnope==0.1.0 # via ipython | |||
There was a problem hiding this comment.
This also changes prod-requirements.txt. Since our servers run linux, I think I'd default to whatever is generated.
With that said, from the linked ticket, it doesn't seem like there's a way to enforce this consistently. I'll create an issue and ping danny on it, to see if he knows more after he gets back from offline time
https://github.com/xhtml2pdf/xhtml2pdf/blob/master/CHANGELOG.txt
Required for python 3 tests.