Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the frontend a module for customview #1313

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

syucream
Copy link
Contributor

@syucream syucream commented Nov 2, 2024

Current custom view is being in chaos ...

  • No official API, so some developers will call various exported variables/functions directly. So custom views will be broken easily with this repo's changes.
  • No node module management for custom views. Mostly it requires to install additional modules in "this" repo.
  • It should require filesystem hack to install custom views, e.g. put their custom views in frontend/src/customview/..., a non-scalable way ...

So I wanna propose a smarter integration way between core (this repo) and custom views. Just providing this frontend implementations as a node module, then make developers to extend it theirselves. Thats like class-extension in some object-oriented languages, class MyCustomView extends PagodaCore { ....
Its an example customview project to extend that with a simple React components.
https://github.com/syucream/pagoda-customview-example

@syucream
Copy link
Contributor Author

syucream commented Nov 9, 2024

Separated a large, independent improvement part as another PR:
#1318

@syucream
Copy link
Contributor Author

Now it works fine with my super simple sample project! https://github.com/syucream/pagoda-customview-example

image

@syucream
Copy link
Contributor Author

syucream commented Nov 15, 2024

And also I've added a workflow to auto-publish the pagoda-core npm module, triggered on a new release tag named pagoda-core-x.y.z.

@syucream syucream marked this pull request as ready for review November 16, 2024 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant