Add the list of attributes that support nullable analysis. #1191
+357
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Include all the nullable analysis attributes in the spec. This will be edited heavily and shrunk down to a smaller set of normative text.
Nigel-Ecma
reviewed
Oct 23, 2024
BillWagner
added
the
meeting: discuss
Nigel-Ecma
reviewed
Oct 25, 2024
jskeet
reviewed
Oct 25, 2024
Co-authored-by: Nigel-Ecma <[email protected]> Co-authored-by: Jon Skeet <[email protected]>
Co-authored-by: Jon Skeet <[email protected]>
jskeet
approved these changes
Oct 28, 2024
Co-authored-by: Nigel-Ecma <[email protected]>
BillWagner
commented
Oct 30, 2024
standard/attributes.md
Outdated
| > } | ||
| > ``` | ||
| > | ||
| > The presence of the attribute helps the compiler in a number of ways. First, the compiler can issue a warning if there's a path where the method can exit without throwing an exception. Second, the compiler can consider any code after a call to that method as unreachable, until an appropriate catch clause is found. Third, the unreachable code won't affect any null states. *end example* |
There was a problem hiding this comment.
This should be reworded. The compiler doesn't use this attribute for definite assignment nor reachability. However, it will only supress any nullability.
When the `DoesNotReturn` attribute is parsed by a compiler that provides nullable diagnostics, that attribute can't impact reachable code analysis.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1092
Based on the last meeting, list the attributes so that their function is normative, however a compiler need not issues warnings based on these rules.