Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the list of attributes that support nullable analysis. #1191

Open
wants to merge 14 commits into
base: draft-v8
Choose a base branch
from

Commits on Oct 22, 2024

  1. Include attribute related text from dotnet#700

    Include all the nullable analysis attributes in the spec. This will be edited heavily and shrunk down to a smaller set of normative text.
    BillWagner committed Oct 22, 2024
    Configuration menu
    Copy the full SHA
    04e93b9 View commit details
    Browse the repository at this point in the history
  2. update the section links

    BillWagner committed Oct 22, 2024
    Configuration menu
    Copy the full SHA
    6b68d9c View commit details
    Browse the repository at this point in the history

Commits on Oct 24, 2024

  1. First set of text updates

    BillWagner committed Oct 24, 2024
    Configuration menu
    Copy the full SHA
    bbdc430 View commit details
    Browse the repository at this point in the history
  2. fix first test run

    BillWagner committed Oct 24, 2024
    Configuration menu
    Copy the full SHA
    e948c02 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    cddb328 View commit details
    Browse the repository at this point in the history
  4. fix final build warning

    BillWagner committed Oct 24, 2024
    Configuration menu
    Copy the full SHA
    4822956 View commit details
    Browse the repository at this point in the history

Commits on Oct 25, 2024

  1. Apply suggestions from code review

    Co-authored-by: Nigel-Ecma <[email protected]>
    Co-authored-by: Jon Skeet <[email protected]>
    3 people authored Oct 25, 2024
    Configuration menu
    Copy the full SHA
    0e91013 View commit details
    Browse the repository at this point in the history
  2. Apply suggestions from code review

    Co-authored-by: Jon Skeet <[email protected]>
    BillWagner and jskeet authored Oct 25, 2024
    Configuration menu
    Copy the full SHA
    c9ceddc View commit details
    Browse the repository at this point in the history
  3. respond to feedback.

    BillWagner committed Oct 25, 2024
    Configuration menu
    Copy the full SHA
    2c9520c View commit details
    Browse the repository at this point in the history
  4. Respond to feedback.

    BillWagner committed Oct 25, 2024
    Configuration menu
    Copy the full SHA
    58b14ce View commit details
    Browse the repository at this point in the history

Commits on Oct 28, 2024

  1. fix tests

    BillWagner committed Oct 28, 2024
    Configuration menu
    Copy the full SHA
    f362a95 View commit details
    Browse the repository at this point in the history
  2. Update attributes.md

    BillWagner committed Oct 28, 2024
    Configuration menu
    Copy the full SHA
    08fae1f View commit details
    Browse the repository at this point in the history

Commits on Oct 29, 2024

  1. Apply suggestions from code review

    Co-authored-by: Nigel-Ecma <[email protected]>
    BillWagner and Nigel-Ecma authored Oct 29, 2024
    Configuration menu
    Copy the full SHA
    034d1ae View commit details
    Browse the repository at this point in the history

Commits on Nov 8, 2024

  1. Don't imply unreachable code

    When the `DoesNotReturn` attribute is parsed by a compiler that provides nullable diagnostics, that attribute can't impact reachable code analysis.
    BillWagner committed Nov 8, 2024
    Configuration menu
    Copy the full SHA
    6771a7f View commit details
    Browse the repository at this point in the history