fix suggestions performance #1008
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Sep 27, 2024
Bunn
approved these changes
Sep 27, 2024
There was a problem hiding this comment.
Tested using a fake set of history items (provided by Brindy)
if HistoryCoordinator.shared.history?.isEmpty == true {
for i in 0 ..< 1000 {
let fakeDomain = "prefix\(Int.random(in: 0..<100)).com"
let url = URL(string: "https://\(fakeDomain)/\(UUID().uuidString)")!
for _ in 0 ..< Int.random(in: 1..<3) {
HistoryCoordinator.shared.addVisit(of: url)
}
HistoryCoordinator.shared.updateTitleIfNeeded(title: "Title of \(fakeDomain)", url: url)
HistoryCoordinator.shared.commitChanges(url: url)
if 0 == (i % 100) {
print("*** added \(i) history entries so far")
}
}
}
LGTM
brindy
added a commit
to duckduckgo/iOS
that referenced
this pull request
Sep 27, 2024
<!-- Note: This checklist is a reminder of our shared engineering expectations. Feel free to change it, although assigning a GitHub reviewer and the items in bold are required.⚠️ If you're an external contributor, please file an issue first before working on a PR, as we can't guarantee that we will accept your changes if they haven't been discussed ahead of time. Thanks! --> Task/Issue URL: https://app.asana.com/0/1201048563534612/1208413716679959/f Tech Design URL: CC: **Description**: Bump BSK to include suggestions performance fix. **Steps to test this PR**: 1. see duckduckgo/BrowserServicesKit#1008 * [ ] Does this PR satisfy our [Definition of Done](https://app.asana.com/0/1202500774821704/1207634633537039/f)? **Copy Testing**: * [ ] Use of correct apostrophes in new copy, ie `’` rather than `'` **Orientation Testing**: * [ ] Portrait * [ ] Landscape **Device Testing**: * [ ] iPhone SE (1st Gen) * [ ] iPhone 8 * [ ] iPhone X * [ ] iPhone 14 Pro * [ ] iPad **OS Testing**: * [ ] iOS 15 * [ ] iOS 16 * [ ] iOS 17 **Theme Testing**: * [ ] Light theme * [ ] Dark theme --- ###### Internal references: [Software Engineering Expectations](https://app.asana.com/0/59792373528535/199064865822552) [Technical Design Template](https://app.asana.com/0/59792373528535/184709971311943)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Required:
Task/Issue URL: https://app.asana.com/0/1201048563534612/1208413716679959/f
iOS PR: duckduckgo/iOS#3405
macOS PR: duckduckgo/macos-browser#3353
What kind of version bump will this require?: Major/Minor/Patch
Optional:
Tech Design URL:
CC:
Description:
Fix suggestions performance issue by just looking at the first 100 sorted local results.
Steps to test this PR: