fix suggestions performance #3405
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bunn
approved these changes
Sep 27, 2024
brindy
added a commit
to duckduckgo/BrowserServicesKit
that referenced
this pull request
Sep 27, 2024
**Required**: Task/Issue URL: https://app.asana.com/0/1201048563534612/1208413716679959/f iOS PR: duckduckgo/iOS#3405 macOS PR: duckduckgo/macos-browser#3353 What kind of version bump will this require?: Major/Minor/Patch **Optional**: Tech Design URL: CC: **Description**: Fix suggestions performance issue by just looking at the first 100 sorted local results. **Steps to test this PR**: 1. Run the app on a local large data source (history entries > 1000 entries ideally) 1. Use autocomplete and check that it doesn't time out for a broad range of matches
# Conflicts: # DuckDuckGo.xcodeproj/project.pbxproj # DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
samsymons
added a commit
that referenced
this pull request
Sep 28, 2024
# By Daniel Bernal (12) and others # Via Daniel Bernal (5) and others * main: (46 commits) Release 7.139.0-4 (#3411) Onboarding highlights experiment updates (#3406) fix suggestions performance (#3405) For third party requests differentiate if they are affiliated with first party (#3386) Bump BSK to pull in C-S-S 6.19.0 (#3396) Release 7.139.0-3 (#3399) Onboarding Highlights Ship Review (#3380) add assertions for tabs in suggestions (#3394) Release 7.139.0-2 (#3398) Bump BSK to Include C.S.S 6.17 (#3397) Bump BSK which includes C.S.S 6.17 (#3395) Rever BSK branch Revert "Bump C.S.S" Bump C.S.S translations for Switch to Tab (#3391) Remove Favorites section header from NTP (#3381) Release 7.139.0-1 (#3389) Add origin to /apps URL (#3378) chery pick returning user fix Release 7.138.1-0 (#3388) ... # Conflicts: # DuckDuckGo/AppDependencyProvider.swift
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/1201048563534612/1208413716679959/f
Tech Design URL:
CC:
Description:
Bump BSK to include suggestions performance fix.
Steps to test this PR:
Copy Testing:
’rather than'Orientation Testing:
Device Testing:
OS Testing:
Theme Testing:
Internal references:
Software Engineering Expectations
Technical Design Template