Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update BSK #3108

Closed
wants to merge 2 commits into from
Closed

Update BSK #3108

wants to merge 2 commits into from

Conversation

SlayterDev
Copy link
Contributor

@SlayterDev SlayterDev commented Aug 15, 2024

Task/Issue URL: https://app.asana.com/0/1163321984198618/1207889813347127/f
Tech Design URL:
CC:

Description:

Steps to test this PR:

  1. No macos changes in this PR

Definition of Done:


Internal references:

Pull Request Review Checklist
Software Engineering Expectations
Technical Design Template
Pull Request Documentation

@SlayterDev SlayterDev self-assigned this Aug 15, 2024
@SlayterDev SlayterDev changed the title Re-Enable Broken Site Toast on iOS Update BSK Aug 15, 2024
@SlayterDev SlayterDev marked this pull request as ready for review August 15, 2024 15:25
SlayterDev added a commit to duckduckgo/BrowserServicesKit that referenced this pull request Aug 22, 2024
<!--
Note: This checklist is a reminder of our shared engineering
expectations.
-->

Please review the release process for BrowserServicesKit
[here](https://app.asana.com/0/1200194497630846/1200837094583426).

**Required**:

Task/Issue URL:
https://app.asana.com/0/1163321984198618/1207889813347127/f
iOS PR: duckduckgo/iOS#3244
macOS PR: duckduckgo/macos-browser#3108
What kind of version bump will this require?: Minor

**Optional**:

Tech Design URL:
CC:

**Description**:
This PR adds the `prompt` entry point back to BSK for the broken site
report.

<!--
Tagging instructions
If this PR isn't ready to be merged for whatever reason it should be
marked with the `DO NOT MERGE` label (particularly if it's a draft)
If it's pending Product Review/PFR, please add the `Pending Product
Review` label.

If at any point it isn't actively being worked on/ready for
review/otherwise moving forward (besides the above PR/PFR exception)
strongly consider closing it (or not opening it in the first place). If
you decide not to close it, make sure it's labelled to make it clear the
PRs state and comment with more information.
-->

**Steps to test this PR**:
1. See [iOS PR](duckduckgo/iOS#3244)
1.

<!--
Before submitting a PR, please ensure you have tested the combinations
you expect the reviewer to test, then delete configurations you *know*
do not need explicit testing.

Using a simulator where a physical device is unavailable is acceptable.
-->

**OS Testing**:

* [ ] iOS 14
* [ ] iOS 15
* [ ] iOS 16
* [ ] macOS 10.15
* [ ] macOS 11
* [ ] macOS 12

---
###### Internal references:
[Software Engineering
Expectations](https://app.asana.com/0/59792373528535/199064865822552)
[Technical Design
Template](https://app.asana.com/0/59792373528535/184709971311943)
@jotaemepereira
Copy link
Collaborator

@SlayterDev I already updated BSK on another PR to 185.1.1, so I believe this is not needed.

@SlayterDev
Copy link
Contributor Author

Thank you @jotaemepereira!

@SlayterDev SlayterDev closed this Aug 26, 2024
@SlayterDev SlayterDev deleted the brad/reenable-toast branch August 26, 2024 00:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants