-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make the trigger of the DDS Pipe callbacks configurable #87
Conversation
610b959
to
51d2e27
Compare
ab9d9e6
to
3a2af19
Compare
3eed1ce
to
3b90b79
Compare
5712e5a
to
68f2984
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #87 +/- ##
==========================================
- Coverage 20.02% 19.64% -0.39%
==========================================
Files 29 29
Lines 2696 2698 +2
Branches 1409 1412 +3
==========================================
- Hits 540 530 -10
- Misses 1699 1721 +22
+ Partials 457 447 -10 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Check that dynamic types work properly.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please change the name and description of the PR (related PRs as well).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Piggyback: please fix the structure of recorder and replayer configuration sections (manual topics and others shouldn't be within topic filtering section). Also note max transmission rate in replayer config is not well placed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please rebase
Signed-off-by: tempate <[email protected]>
Signed-off-by: tempate <[email protected]>
Signed-off-by: tempate <[email protected]>
Signed-off-by: tempate <[email protected]>
Signed-off-by: tempate <[email protected]>
Signed-off-by: tempate <[email protected]>
Signed-off-by: tempate <[email protected]>
Signed-off-by: tempate <[email protected]>
Signed-off-by: tempate <[email protected]>
Signed-off-by: tempate <[email protected]>
Signed-off-by: tempate <[email protected]>
Signed-off-by: tempate <[email protected]>
cf8d465
to
c0cc609
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
In the previous version, the DDS Pipe's callbacks were only triggered by the discovery of readers, so the DDS-Record-Replay had to simulate the creation of a reader to trigger the creation of the Bridge. In this version, the entity type that triggers the callbacks is configurable. The DDS Recorder triggers them with the discovery of writers, and the DDS Replayer doesn't trigger them by discovery, and just starts replaying the data as soon as the program is launched.
Merge after: