Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[21980] Fix sequence of alias of primitives inside modules #415

Merged
merged 3 commits into from
Nov 5, 2024

Conversation

richiware
Copy link
Member

@richiware richiware commented Oct 23, 2024

Description

This PR fixes a corner case with sequences of alias of primitives inside modules. The generated code doesn't compile due to how the type name is generated.

module Common_Module
{
   typedef char My_Char;
   typedef sequence<My_Char, 20> My_String;
};

module NoCommon_Module
{
   typedef Common_Module::My_String My_AliasString;
   typedef sequence<My_AliasString> My_SequenceString;

   struct My_Structure
   {
       My_SequenceString list;
   };
};

Depends on:

Contributor Checklist

  • Commit messages follow the project guidelines.
  • Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
  • N/A New feature has been documented/Current behavior is correctly described in the documentation.
  • N/A Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

@richiware richiware changed the title Bugfix/sequence namespace [21980] Fix sequence of alias of primitives inside modules Oct 23, 2024
Signed-off-by: Ricardo González Moreno <[email protected]>
Signed-off-by: Ricardo González Moreno <[email protected]>
@Mario-DL Mario-DL added this to the v4.0.3 milestone Oct 28, 2024
Mario-DL
Mario-DL previously approved these changes Oct 28, 2024
Copy link
Member

@Mario-DL Mario-DL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with green CI

@Mario-DL Mario-DL requested review from Mario-DL and removed request for Mario-DL October 28, 2024 13:13
@github-actions github-actions bot added the ci-pending PR which CI is running label Oct 28, 2024
Signed-off-by: Ricardo González Moreno <[email protected]>
@Mario-DL Mario-DL added ready-to-merge Ready to be merged. CI and changes have been reviewed and approved. and removed ci-pending PR which CI is running labels Oct 30, 2024
@richiware richiware merged commit 84a9fe8 into master Nov 5, 2024
4 checks passed
@richiware richiware deleted the bugfix/sequence-namespace branch November 5, 2024 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge Ready to be merged. CI and changes have been reviewed and approved.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants