[22043] Call Cdr::set_dds_cdr_options() when TypeSupport encodes (backport #417) #418
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![mergify[bot]](https://avatars.githubusercontent.com/in/10562?s=60&v=4){kind=small}
Signed-off-by: Ricardo González Moreno <[email protected]> (cherry picked from commit b3cf046)
7 tasks
|
@richiware This fails building with Fast CDR 1.x |
MiguelCompany
requested changes
Nov 5, 2024
| @@ -142,6 +142,7 @@ bool $struct.name$PubSubType::serialize( | |||
| ser.serialize_encapsulation(); | |||
| // Serialize the object. | |||
| ser << *p_type; | |||
| ser.set_dds_cdr_options({0,0}); | |||
There was a problem hiding this comment.
Suggested change
| ser.set_dds_cdr_options({0,0}); | |
| #if FASTCDR_VERSION_MAJOR > 1 | |
| ser.set_dds_cdr_options({0,0}); | |
| #else | |
| ser.setDDSCdrOptions(0); | |
| #endif // FASTCDR_VERSION_MAJOR > 1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
According with new
fastcdrAPI usage, the generated code should callCdr::set_dds_cdr_options().Depends on:
@Mergifyio backport 3.3.x
Contributor Checklist
Commit messages follow the project guidelines.
N/A Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
N/A New feature has been documented/Current behavior is correctly described in the documentation.
Applicable backports have been included in the description.
Reviewer Checklist
This is an automatic backport of pull request #417 done by [Mergify](https://mergify.com).