Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new FBType GEN_PULSE_DIST for Distance based Impulse Generator. #644

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

franz-hoepfinger-4diac
Copy link

@franz-hoepfinger-4diac franz-hoepfinger-4diac commented Oct 18, 2024

Add new FBType GEN_PULSE_DIST for Distance based Impulse Generator.

Typical usage:

this would e.g. paint the middle dash-line on a Street:
5000 Line, with 5000 Gap.

image

Copy link

github-actions bot commented Oct 18, 2024

Test Results

   110 files  ±0     110 suites  ±0   48s ⏱️ ±0s
27 531 tests  - 2  27 531 ✅  - 2  0 💤 ±0  0 ❌ ±0 
27 532 runs   - 2  27 532 ✅  - 2  0 💤 ±0  0 ❌ ±0 

Results for commit 6dddf5e. ± Comparison against base commit b2b0d82.

This pull request removes 2 tests.
org.eclipse.fordiac.ide.structuredtextfunctioneditor.tests.STFunctionValidatorPartialAccessTest ‑ testValidPartialAccessOnArraySubscript
org.eclipse.fordiac.ide.structuredtextfunctioneditor.ui.tests.STFunctionMultiQuickfixTest ‑ fixUnnecessaryConversionNested

♻️ This comment has been updated with latest results.

@franz-hoepfinger-4diac
Copy link
Author

franz-hoepfinger-4diac commented Oct 18, 2024

Make Sense to add a Distance Offset!

image

…Add new input variable for distance offset in the impulse generator.
Copy link
Contributor

@azoitl azoitl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please don't use the GEN_ prefix for such blocks. The GEN_ prefix is used in Eclipse 4diac for configurable types (e.g., publish). Also distance is maybe not the best name as I could feed it any value to generate pulses.

Would RangeBasedPulse be better?

@diplfranzhoepfinger
Copy link

Please don't use the GEN_ prefix for such blocks. The GEN_ prefix is used in Eclipse 4diac for configurable types (e.g., publish).

sorry, yes, normally i know this. 

 Also distance is maybe not the best name as I could feed it any value to generate pulses.

you are right. it might be Time, it might be Distance, or it might be any Value from any Source. 

e.g. generate Pulses dependent of a Sensor Value. 

Would RangeBasedPulse be better?

yes, will change

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants