Create codeql.yml #526
Closed
Create codeql.yml #526
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
was ArrayIndexOutOfBoundsException eclipse-jdt/eclipse.jdt.ui#740
Signed-off-by: Rob Stryker <[email protected]> Fixes as per review Signed-off-by: Rob Stryker <[email protected]>
- Also fix test cases - Also Bump jdt.ui.tests.refactoring Signed-off-by: Rob Stryker <[email protected]>
Change the default settings of the built-in clean-up profile and in the "Additional actions" of the "Save Actions"; set them to always use brackets for blocks of code (even for one-liners). These settings are just the defaults, they can be overwritten. Fixes eclipse-jdt/eclipse.jdt.ui#667
* Don't offer to add type parameters to var type variable - add var checks to Java50FixCore.createRawTypeReferenceOperation() - make some static methods public in Java50FixCore regarding raw type reference checking - add var checking to LocalCorrectionsSubProcessor - add new LocalCorrectionsQuickFixTest10 - fixes #765
- Move to common instead of unnecessary new source folder - Cleanup unused Messages constant - Also bump jdt.core.manipulation Signed-off-by: Rob Stryker <[email protected]>
…up (#752) - retain the comment for the declared variable that is cast to the type in the instanceof expression that will be converted to instanceof pattern - modify existing test in CleanUpTest16 - fixes #729
- fixes #743 - add new test to JavadocHoverTests
…oo (#771) - add text block partitions to ignore logic in JavaSpellingEngine - replaces #707 - fixes #770
* Extracting RefactorSaveHelper constants into core Signed-off-by: Rob Stryker <[email protected]>
Reusing a IProgressManager requires to finally call progressMonitor.done() before using it again. see https://bugs.eclipse.org/bugs/show_bug.cgi?id=485748 and eclipse-jdt/eclipse.jdt.ui#773
getResourceAttributes() can return null eclipse-jdt/eclipse.jdt.ui#738
Signed-off-by: Rob Stryker <[email protected]> Update copyright header Signed-off-by: Rob Stryker <[email protected]>
…s for jface.util.Util.replaceAll to break UI dep (#712) More cleanup Signed-off-by: Rob Stryker <[email protected]> Co-authored-by: Rob Stryker <[email protected]>
* Enable quick assist for deprecated calls to also be a quick fix - move some code from QuickAssistProcessor.getDeprecatedProposal() into QuickAssistProcessorUtil.isDeprecatedMethodCallWithReplacement() - change QuickAssistProcessor.getDeprecatedProposal() to use new method and to also fail if there is a deprecated method call problem for the selection in which case leave the proposal as a quick fix - add new logic into QuickFixProcessor to handle IProblem.UsingDeprecatedMethod using similar logic to quick assist - add new tests to QuickFixTest1d8 - fixes #721
…salModel and associated classes (#716) * Migrate core extension classes to use the Core version of LinkedProposalModel and associated classes * CompilationUnitRewriteOperation and subclasses should use LinkedProposalModelCore * Minor version bump for jdt.ui Signed-off-by: Rob Stryker <[email protected]>
* Propose import quick fix for missing annotation value - modify QuickFixProcessor to recognize an UndefinedVariable error for an annotation value and propose import if possible - add new tests to QuickFixTest1d8 - fixes #717
…to jdt.core.manipulations (#776) Refactor Signed-off-by: Rob Stryker <[email protected]> Co-authored-by: Rob Stryker <[email protected]>
…ld (#778) * Don't make a field final if used in lambda exp used to initialize field - if an uninitialized field is used inside a lambda expression to initialize another field, it cannot be made final - add this logic to VariableDeclarationFixCore - add new test to CleanUpTest1d8 - fixes #769
…rce and project utility functions Signed-off-by: Rob Stryker <[email protected]> wrong since tag Signed-off-by: Rob Stryker <[email protected]>
Signed-off-by: Rob Stryker <[email protected]>
newTypeHierarchy is a JavaModelOperation which uses SubMonitor.convert since https://bugs.eclipse.org/bugs/show_bug.cgi?id=477790 That is not allowed when beginTask is already called. See SubMonitor.convert javadoc. eclipse-platform/eclipse.platform.ui#1107
…vailabilityTesterCore, and fix callers where necessary (#777) Refactor RefactoringAvailbilityTester methods to RefactoringAvailabilityTesterCore Signed-off-by: Rob Stryker <[email protected]> Co-authored-by: Rob Stryker <[email protected]>
enhanced switch statement eclipse-jdt/eclipse.jdt.ui#783
- make sure before creating a change operation that any InfixExpression that has NLS tags has either a Statement or FieldDeclaration ancestor in StringConcatToTextBlockFixCore - add new tests to CleanUpTest15 - fixes #779
* Improve hover for Java hex, octal, and binary constants Show hovers also in the following cases: int bin1 0B11111111; // uppercase "0B" int bin2 0b1111_1111; // binary with an underscore int oct = 0_377; // octal with an underscore int hex = 0xff_ff_ff; // hex with underscores long l = 0X45L; // long with suffix and upper-case X double x = 0Xff00p0d; // double starting with 0X Do not show hovers for doubles starting with "0", e.g.: double d= 01e6D; Hover for Java hex, octal, and binary constants has been introduced by: eclipse-jdt/eclipse.jdt.ui#640 Co-authored-by: Jeff Johnston <[email protected]>
* Fix build test errors due to AST API >= 20 - new AST for 20 and up changes PatternInstanceofExpression and this needs to be accommodated in some refactoring logic - change SuperTypeConstraintsCreator and SurroundWithTryCatchAnalyzer and PatternMatchingForInstanceofFixCore to handle updated version of PatternInstanceofExpression - for #745
…h no return type (#1142) Signed-off-by: Rob Stryker <[email protected]> Co-authored-by: Rob Stryker <[email protected]>
Signed-off-by: Rob Stryker <[email protected]> Co-authored-by: Rob Stryker <[email protected]>
to use public API instead of type cast. Failing since I20240130-1800 Java nature and java project are now implemented as separate instances eclipse-jdt/eclipse.jdt.core#1916
CleanUpOptions @noextend is not intended to be subclassed by CLIENTS.
tested with System.gc() behind ExtractInterfaceTests1d8.testExtractInterfaceFromInterface2()
- add missing synchronization for getCurrentChange() which accesses fChange which is created in a synchronized method - potential fix for #1136
The type ThreadDeath has been deprecated since version 20 and marked for removal
The method createImage(ImageDescriptor) from the type ResourceManager is deprecated since version 3.31
* Move some core code into ReorgCorrectionBaseSubProcessor Signed-off-by: Rob Stryker <[email protected]>
There is no plan to change the implementation
- fixes #963 - add new test to CleanUpTest1d8
…d IProblemLocationCore) - Removal of internal interfaces IInvocationContextCore and IProblemLocationCore Signed-off-by: Rob Stryker <[email protected]>
…ed (#1177) * Add checking so no invalid extract local variable proposals are offered - fix ExtractTempRefactoring.checkFinalConditions() to recognize an empty edit and set refactoring status to info with failure message - also fix the method to register it has been run and to save the refactoring status code - fix QuickAssistProcessor.getExtractVariableProposal() to run the checkFinalConditions() method of the extract temp refactorings and to not offer a proposal if the status is not OK - add new tests to ExtractTempTests and AssistQuickFixTest
- Remove internal interface ICleanUpCore - Remove CleanUpFixWrapper, as it is no longer necessary - Remove unused CleanUpCoreWrapper Signed-off-by: Rob Stryker <[email protected]>
…iFixCore Signed-off-by: Rob Stryker <[email protected]>
… (#1182) * Don't offer extract to constant unless expression is final and static - fixes #1180 - add new logic to QuickAssistProcessor.getExtractVariableProposal() - add new tests to AssistQuickFixTest
…xCore) - Delete internal interface IMultiFixCore & ILinkedFixCore, plus small cleanup Signed-off-by: Rob Stryker <[email protected]>
* Fix UI freeze due to extract to local computations - fixes #1185 - don't run checkFinalConditions() from QuickAssistProcessor to see if extract to local variable proposals are valid - override the preview for extract to local variable and extract to local variable (replace all occurrences) so they just display a message instead of creating the change - fix ExtractTempRefactoring.checkFinalConditions() to recognize an invalid change in which case add a fatal error status with a code from RefactoringStatusCodes - modify RefactoringCorrectionProposalCore to recognize the error and create a dummy edit plus a log entry to note that the extraction will not occur - fix AssistQuickFixTest tests proposal counts
* use concurrent datastructures, volatile fConflict * do not spinloop burning cpu Co-authored-by: Jörg Kubitz <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.