Create codeql.yml #526

eclipse-platform/eclipse.platform.releng.aggregator#1318

Tracked by eclipse-platform/eclipse.platform.releng.aggregator#1319

was ArrayIndexOutOfBoundsException eclipse-jdt/eclipse.jdt.ui#740

Signed-off-by: Rob Stryker <[email protected]> Fixes as per review Signed-off-by: Rob Stryker <[email protected]>

- Also fix test cases - Also Bump jdt.ui.tests.refactoring Signed-off-by: Rob Stryker <[email protected]>

Change the default settings of the built-in clean-up profile and in the "Additional actions" of the "Save Actions"; set them to always use brackets for blocks of code (even for one-liners). These settings are just the defaults, they can be overwritten. Fixes eclipse-jdt/eclipse.jdt.ui#667

* Don't offer to add type parameters to var type variable - add var checks to Java50FixCore.createRawTypeReferenceOperation() - make some static methods public in Java50FixCore regarding raw type reference checking - add var checking to LocalCorrectionsSubProcessor - add new LocalCorrectionsQuickFixTest10 - fixes #765

- Move to common instead of unnecessary new source folder - Cleanup unused Messages constant - Also bump jdt.core.manipulation Signed-off-by: Rob Stryker <[email protected]>

…up (#752) - retain the comment for the declared variable that is cast to the type in the instanceof expression that will be converted to instanceof pattern - modify existing test in CleanUpTest16 - fixes #729

- fixes #743 - add new test to JavadocHoverTests

…oo (#771) - add text block partitions to ignore logic in JavaSpellingEngine - replaces #707 - fixes #770

* Extracting RefactorSaveHelper constants into core Signed-off-by: Rob Stryker <[email protected]>

Reusing a IProgressManager requires to finally call progressMonitor.done() before using it again. see https://bugs.eclipse.org/bugs/show_bug.cgi?id=485748 and eclipse-jdt/eclipse.jdt.ui#773

getResourceAttributes() can return null eclipse-jdt/eclipse.jdt.ui#738

Signed-off-by: Rob Stryker <[email protected]> Update copyright header Signed-off-by: Rob Stryker <[email protected]>

…s for jface.util.Util.replaceAll to break UI dep (#712) More cleanup Signed-off-by: Rob Stryker <[email protected]> Co-authored-by: Rob Stryker <[email protected]>

* Enable quick assist for deprecated calls to also be a quick fix - move some code from QuickAssistProcessor.getDeprecatedProposal() into QuickAssistProcessorUtil.isDeprecatedMethodCallWithReplacement() - change QuickAssistProcessor.getDeprecatedProposal() to use new method and to also fail if there is a deprecated method call problem for the selection in which case leave the proposal as a quick fix - add new logic into QuickFixProcessor to handle IProblem.UsingDeprecatedMethod using similar logic to quick assist - add new tests to QuickFixTest1d8 - fixes #721

…salModel and associated classes (#716) * Migrate core extension classes to use the Core version of LinkedProposalModel and associated classes * CompilationUnitRewriteOperation and subclasses should use LinkedProposalModelCore * Minor version bump for jdt.ui Signed-off-by: Rob Stryker <[email protected]>

* Propose import quick fix for missing annotation value - modify QuickFixProcessor to recognize an UndefinedVariable error for an annotation value and propose import if possible - add new tests to QuickFixTest1d8 - fixes #717

…to jdt.core.manipulations (#776) Refactor Signed-off-by: Rob Stryker <[email protected]> Co-authored-by: Rob Stryker <[email protected]>

…ld (#778) * Don't make a field final if used in lambda exp used to initialize field - if an uninitialized field is used inside a lambda expression to initialize another field, it cannot be made final - add this logic to VariableDeclarationFixCore - add new test to CleanUpTest1d8 - fixes #769

…rce and project utility functions Signed-off-by: Rob Stryker <[email protected]> wrong since tag Signed-off-by: Rob Stryker <[email protected]>

Signed-off-by: Rob Stryker <[email protected]>

newTypeHierarchy is a JavaModelOperation which uses SubMonitor.convert since https://bugs.eclipse.org/bugs/show_bug.cgi?id=477790 That is not allowed when beginTask is already called. See SubMonitor.convert javadoc. eclipse-platform/eclipse.platform.ui#1107

…vailabilityTesterCore, and fix callers where necessary (#777) Refactor RefactoringAvailbilityTester methods to RefactoringAvailabilityTesterCore Signed-off-by: Rob Stryker <[email protected]> Co-authored-by: Rob Stryker <[email protected]>

enhanced switch statement eclipse-jdt/eclipse.jdt.ui#783

- fixes #695

- make sure before creating a change operation that any InfixExpression that has NLS tags has either a Statement or FieldDeclaration ancestor in StringConcatToTextBlockFixCore - add new tests to CleanUpTest15 - fixes #779

* Improve hover for Java hex, octal, and binary constants Show hovers also in the following cases: int bin1 0B11111111; // uppercase "0B" int bin2 0b1111_1111; // binary with an underscore int oct = 0_377; // octal with an underscore int hex = 0xff_ff_ff; // hex with underscores long l = 0X45L; // long with suffix and upper-case X double x = 0Xff00p0d; // double starting with 0X Do not show hovers for doubles starting with "0", e.g.: double d= 01e6D; Hover for Java hex, octal, and binary constants has been introduced by: eclipse-jdt/eclipse.jdt.ui#640 Co-authored-by: Jeff Johnston <[email protected]>

* Fix build test errors due to AST API >= 20 - new AST for 20 and up changes PatternInstanceofExpression and this needs to be accommodated in some refactoring logic - change SuperTypeConstraintsCreator and SurroundWithTryCatchAnalyzer and PatternMatchingForInstanceofFixCore to handle updated version of PatternInstanceofExpression - for #745

…f bounds for length 1 (#724) fixes #1294 + Also fix it for TYPE_USE annotations + Test nesting in lambda instead of anonymous + additional fix for similar problem caused by varargs signature + require latest o.e.jdt.core.compiler.batch

* Fix build test errors due to AST API >= 20 - new AST for 20 and up changes PatternInstanceofExpression and this needs to be accommodated in some refactoring logic - change SuperTypeConstraintsCreator and SurroundWithTryCatchAnalyzer and PatternMatchingForInstanceofFixCore to handle updated version of PatternInstanceofExpression - for #745

For eclipse-jdt/eclipse.jdt.core#1380

- modify endVisit(Type) to support all AST api levels 21 and below

findPackageFragmentRoot() searches through all PackageFragment Roots for every IContainer.member. This can be slow due to involved file access. see eclipse-jdt/eclipse.jdt.core#303 Instead call getAllPackageFragmentRoots() only once, index the result and use O(1) hash access.

To avoid sorting using toString() which uses org.eclipse.jdt.internal.core.JavaElement.toStringChildren(int, StringBuffer, Object) on every project ...

* Do further improvements to Java constant hover - add logic to do unsigned parsing and to do Integer parsing when l/L suffix is missing - add negation support - add floating-point exponent sign support - fixes #795

For eclipse-jdt/eclipse.jdt.core#1380

…nge (#786) The class org.eclipse.osgi.service.resolver.VersionRange belongs to the outdated org.eclipse.osgi.service.resolver package and already inherits org.osgi.framework.VersionRange. Additionally in P2Utils.findBundle() the check if the bundle file exists is deferred to the latest possibility in order to speed-up the search if multiple versions are present and avoids a NPE if the bundle-file cannot be determined.

* Remove reference to Y-builds in pom.xml * More version bumps

* Enable quick assist for deprecated calls to also be a quick fix - move some code from QuickAssistProcessor.getDeprecatedProposal() into QuickAssistProcessorUtil.isDeprecatedMethodCallWithReplacement() and add type modifier checking - change QuickAssistProcessor.getDeprecatedProposal() to use new method and to also fail if there is a deprecated method call problem for the selection in which case leave the proposal as a quick fix - add new logic into QuickFixProcessor to handle IProblem.UsingDeprecatedMethod using similar logic to quick assist - add new tests to QuickFixTest1d8 - create InlineDeprecatedMethodCleanUpCore - add new logic to InlineMethodFixCore - make QuickAssistProcessorUtil.findCUForMethod() public - change order of cleanups so Variable cleanups are done after deprecated inlining as this causes problems otherwise - fixes #721

* Extract Similar Expression in All Methods If End-Users Want Co-authored-by: Jeff Johnston <[email protected]>

Fixes number of selected cleanups. Since CleanUpTabPage.registerSlavePreference calls registerPreference(master) again. eclipse-jdt/eclipse.jdt.ui#797 Co-authored-by: Jörg Kubitz <[email protected]>

…808) Give it a max of 30s per test instead of 5s. This doesn't slow down the tests execution, it just lets the tests run a bit longer if the hardware is slow. Fixes eclipse-jdt/eclipse.jdt.ui#699

…nces (#810) * Move folder to jdt.core.manipulations; Replace plugin-specific references Signed-off-by: Rob Stryker <[email protected]> Signed-off-by: Rob Stryker <[email protected]> Co-authored-by: Rob Stryker <[email protected]>

- add new quick assist to rename a final static constant to follow constant name syntax (upper-case with underscores) Co-authored-by: Jeff Johnston <[email protected]>

- standardize all internal code on IProblemLocationCore wherever possible - have IProblemLocation extend IProblemLocationCore - add new constructor to ProblemLocation to wrap an IProblemLocationCore Signed-off-by: Rob Stryker <[email protected]> Co-authored-by: Rob Stryker <[email protected]>

- fixes #820

…all cleanup (#814) - move some constants into jdt.core.manipulation from jdt.ui which are pre-requisites to many proposals being moved down into jdt.core.manipulation for various headless consumers like jdt.ls. Signed-off-by: Rob Stryker <[email protected]> Co-authored-by: Rob Stryker <[email protected]>

… the extracted expression is a method invocation (#685) * add more verbs that should be removed from method call to form variable name Co-authored-by: Jeff Johnston <[email protected]>

- split the proposal logic into core and U moving the vast majority of the logic into the core classes - maintain existing UI non-core classes as wrappers for stability. - create IInvocationContextCore class and makes it the default interface for use in the core classes Signed-off-by: Rob Stryker <[email protected]> Co-authored-by: Rob Stryker <[email protected]> Co-authored-by: Jeff Johnston <[email protected]>

#438) * Apply semantic syntax coloring in Java source hover viewer. Fixes #437 Also fixes source line trimming not considering indentation of 1st line of java element source segment causing all remaining lines to be left indented after trimming. * Do not delay showing java source viewer until after semantic coloring Instead of delaying, turn off redrawing of source viewer for the duration of coloring job & application of it's results to viewer text to prevent seeing intermediate content changes. * Use hidden source viewer instead of displayed one for semantic coloring Compared to using displayed viewer with disabled redrawing, this approach should prevent visible text modifications to displayed source viewer on all platforms.

- add createTextChange() that uses delegate into FixCorrectProposal - add getRelevance() method to call delegate as well - fixes #826

- new split of proposals into jdt.core.manipulation changed the computeNumberOfFixesForCleanUp() method to be passed an ICleanUpCore that is wrappered to be an ICleanUp but this code looks for an IMultiFix which gets lost in wrapping - change computeNumberOfFixesForClean() to use the fCleanUp field that is already stored and is an ICleanUp - fix getCleanUp() to return fCleanUp - fix AbstractAnnotationHover.createCompletionProposalsList() to just call proposal.getCleanUp() and don't do any wrapping

- add check for being in Annotation before looking to see if NLS comments are set up - bail if NLSUtil.scanCurrentLine() fails - add new tests to CleanUpTest15 - add new setup method to Java15ProjectTestSetup to make annotations accessible - fixes #824

@param

See https://download.eclipse.org/eclipse/downloads/drops4/I20230925-1800/compilelogs/jdt.doc.isv.javadoc.txt ../../../eclipse.jdt.ui/org.eclipse.jdt.ui/ui/org/eclipse/jdt/ui/text/java/correction/CUCorrectionProposal.java:147: error: @param name not found * @param delegate to set ^ Regression from 816a5d2

The manipulation bundle already marks other split packages with manipulation=split;mandatory:=manipulation This add the same thing to the newly split packages: org.eclipse.jdt.internal.corext.refactoring.reorg org.eclipse.jdt.internal.corext.refactoring

* Revert "Mark newly split packages with mandatory directives (#833)" This reverts commit cd6cf28. * Revert "Javadoc error fix for CUCorrectionProposal.setDelegate()" This reverts commit 819ec65. * Revert "Fix FixCorrectionProposal to properly handle IMultiFix cleanups (#829)" This reverts commit 31839df. * Revert "Add back some missing methods to FixCorrectionProposal (#827)" This reverts commit 6f79122. * Revert "Proposals branch (#815)" This reverts commit 816a5d2. - fixes #835

- fixes #780 - add new test to CleanUpTest16

- add new name checking logic so the chosen loop var name is not already used - add some logic to remove added imports if they are found in the current file - add new test to CleanUpTest1d8 - fixes #798

As we had introduced changes in getRawChildren to return remaining elements as children for ExpandableNode we had to explicitly make this change. Now we don't return remaining elements as children for ExpndableNode. See eclipse-platform/eclipse.platform.ui#1097

Signed-off-by: Rob Stryker <[email protected]>

'Link with Editor' tries to select visible parent in case of element being linked is not created yet on tree viewer. Similar implementation is used for 'Show In' Fixes eclipse-platform/eclipse.platform.ui#1014

Revise the patch to refactor proposals logic into jdt.core.manipulation - split the proposal logic into core and U moving the vast majority of the logic into the core classes - maintain existing UI non-core classes as wrappers for stability. - create IInvocationContextCore class and makes it the default interface for use in the core classes - mark newly split packages with mandatory directives (#833) Signed-off-by: Rob Stryker <[email protected]> Co-authored-by: Rob Stryker <[email protected]> Co-authored-by: Jeff Johnston <[email protected]> Co-authored-by: Andrey Loskutov <[email protected]> Co-authored-by: Thomas Watson <[email protected]>

- modify VariableDeclarationFixCore to add a check for a field that is written in a constructor but is referred to prior to the write in a lambda - add new test to CleanUpTest1d8 - fixes #769

pattern in switch #850 Fixes eclipse-jdt/eclipse.jdt.ui#850

Signed-off-by: Rob Stryker <[email protected]> Co-authored-by: Rob Stryker <[email protected]>

- fixes #774 - add var check in InferTypeArgumentsRefactoring.rewriteTypeVariable() - make Java50FixCore.getRawReference() method public - modify LocalCorrectionsSubProcessor.referencesVar() method to handle more cases - add new test to LocalCorrectionsQuickFixText10

- fix add unimplemented methods to recognize when an abstract method is implemented via a parameterized type - add new test to AddUnimplementedMethodsTests1d8 - fixes #863

The tests seem to work just fine without it and the IDE keeps removing it for me anyway, which shows a change to be committed and it's annoying.

- fix OrganizeImportsOperation.addStaticImports() to not return when static favorite imports preference is unset - add new test to ImportOrganizeTest - fixes #853

* Fix StringBuffer to StringBuilder cleanup - fixes #869 - add logic to handle StringWriter.getBuffer() and other binary methods returning StringBuffer - add new test scenario to CleanUpTest1d8

If there is a main method candidate it ensures that the class is runnable. JavaModelUtils is used in JavaElementImageProvider and this change makes classes with instance main methods being shown as runnable in the Outline view if running on Java 21 with --enable-preview set.

…#880) * Bug 538832 - [quick assist] Remove non-sensical assign-to proposals - fixes https://bugs.eclipse.org/bugs/show_bug.cgi?id=538832 - don't add proposals for assigning to various fields if one field has a matching name to a parameter - add new test to AssistQuickFixTest - specify --release 8 for jdt.ui.junit.sampleproject - Remove warnings in jdt.ui.junit.sampleproject

This adds the infrastructure for disabling the adding of vintage engine/junit4 to the classpath of the JUnit5 container. See eclipse-jdt/eclipse.jdt.ui#837

… (#892) - add logic to Bindings.getBindingOfParentTypeContext to handle records - add new ImportOrganizeTest16 - fixes #890

A VM property with name 'JDT_JUNIT5_RUNNER_STOP_REQUESTED' is set when the JUnit view requested to stop JUnit 5 test execution. This property can be used by test frameworks based on JUnit, to stop test execution. JUnit 5 itself doesn't yet support stopping test execution. Partial workaround for: #889

This change throws an OutOfMemoryError before a test starts (via TestExecutionListener), if the JUnit view requested a test execution stop during JUnit 5 tests. An OOME is the only type of exception that is not swallowed by the JUnit 5 framework, when notifying a TestExecutionListener. Fixes: eclipse-jdt/eclipse.jdt.ui#889

The methods override the default empty implementation with the same empty implementation. This yields an unnecessary "info" in the problems view

Apply the result of eclipse-pde/eclipse.pde#730

switch statement Fixes eclipse-jdt/eclipse.jdt.ui#881

to reduce ecj warnings

* Fix NPE in QuickAssistProcessorUtil - fixes #917 - fix API errors in JDT UI build

tracked in eclipse-platform/eclipse.platform.releng.aggregator#1557

- Also version bump jdt.core.manipulation Signed-off-by: Rob Stryker <[email protected]>

…#937) * Fix JavaSource hover not displayed from ClassFileEditor. Fixes #936 * Bump up JDT UI --------- Co-authored-by: Jeff Johnston <[email protected]>

* Enable StringBuffer to Text Block quick assist - fix logic in QuickAssistProcessor.getStringConcatToTextBlockProposal() to also support StringBuffer or StringBuilder variable declaration that can be converted to Text Block - add new test to AssistQuickFixTest15 - fixes #882 * Bump up JDT UI tests

* Fix Externalize Strings when input is a Text Block - fixes: #906 - fix NLSHint.stripQuotes() to recognize a text block - add new NLSHintStripQuotesTest class * Add additional tests to NLSHintStripQuotesTest * Bump up o.e.jdt.ui.tests.refactoring

* Allow generate constructor using fields on class with no fields - add new constructor to SourceActionDialog to accept flag that allows empty tree and pass this on to super class - remove zero fields test in GenerateConstructorUsingFieldsAction - add new test to GenerateConstructorUsingFieldsTest

…#909) Extract the conditions into variables and merge the removed if with the following else-if to make its intention a bit clearer.

- Do not recompute favorite static imports for an unknown type - Reuse compilation unit working copy in code completion logic Signed-off-by: Roland Grunberg <[email protected]>

for example eclipse-jdt/eclipse.jdt.core#1624

- jdt.core.manipulation received an unnecessary minor version bump, where a service bump was sufficient Signed-off-by: Roland Grunberg <[email protected]>

to avoid false positive API errors in tycho builds

@return

This commit cleans up Javadoc that does not add information. It resolves ecj warnings: `Javadoc: Description expected after ...` It helps to prevent future empty javadoc by disabling missingJavaDoc warnings. This resolves `Javadoc: Missing ...` The modification is a result of regular expression search&replace: in files `*.java` `^[\s]*\*[\s]*(@return|@param[\s]*[^\s]+|@throws[\s]*[^\s]+)\R([\s]*\*[\s]*@|[\s]*\*/\R)` ->`$2` `^([\s]*\*[\s]*\R)([\s]*\*/\R)` ->`$2` `^[\S\t ]*/\*\*\R[\s]*\*/\R` ->`` in files `org.eclipse.jdt.core.prefs` `org\.eclipse\.jdt\.core\.compiler\.problem\.missingJavadoc(Comments|Tags)\=[^\s]*` ->`org\.eclipse\.jdt\.core\.compiler\.problem\.missingJavadoc$1\=ignore` excludes files in org.eclipse.jdt.text.tests/testResources org.eclipse.jdt.ui.tests.refactoring/resources

reduce ecj warnings in workspace

`The expression of type _ is boxed into _` - not a problem `Empty block should be documented` - not a problem `The allocated object is never used` - normal for SWT `The switch statement should have a default case` `_ is a raw type. References to generic type _<E> should be parameterized` - new code is reviewed anyway and nobody takes time to refactor the old raw types Also includes some minor warning fixes

was NPE see eclipse-jdt/eclipse.jdt.ui#929

Some files were checked-in into git having windows style line endings (\r\n). This is in general not wanted because it can cause modified files without any difference in git-staging on Windows if auto-crlf is enabled. To re-normalize line endings of all files use the following command (including dot): git add --renormalize .

This enables pomless builds for JDT UI and removes the simple pom files. Future commits can reduce the usage of pom files further. For #948

…921) - Small checks and behavior differences for refactorings and assists for headless consumers (jdt.ls) Signed-off-by: Rob Stryker <[email protected]>

When running JUnit 5 @testtemplate tests, extra test suites are shown in the JUnit view to represent the tests in the template. Those suites introduce unnecessary noise when the template contains only one test - e.g. when repeating tests that failed. This change adjusts TestSuiteElement.getChildren(), pruning each TestSuiteElement that has a single TestCaseElement child that is also a dynamic test. Fixes: #945 Signed-off-by: Simeon Andreev <[email protected]>

Using https://github.com/eclipse-tycho/tycho/wiki/Tycho-Pomless#overwrite-group-and-artifact-ids we restore the group id to org.eclipse.jdt.feature for features and org.eclipse.jdt for plug-ins

eclipse-jdt/eclipse.jdt.core#1681

The selection listener code assumes the good selection should always have exact one element and only from given type. Let make this code more verbose to reflect the original intent. See eclipse-platform/eclipse.platform.ui#1360

- Helper method createNewCompilationUnit should always return an array. Signed-off-by: Roland Grunberg <[email protected]>

to reduce warnings

via quickfix

get rid of "At least one of the problems in category 'javadoc' is not analysed due to a compiler option being ignored" warnings

- fix StringConcatToTextBlockFixCore to not bail on a method parameter or assignment where a method is called and the result of the method is not String - add new test scenarios to CleanUpTest15 - fixes #935

* Prevent NPE in string concat to text block cleanup - add null check for originalVarName field in StringConcatToTextBlockFixCore.visit(ClassInstanceCreation) - fixes: #950 - add new test scenarios to CleanUpTest15

* Remove useless see tags * Use pattern matching

Their deps already did that so it actually fixes couple of warnings in the workspace.

It is a plain oversight as I can not imagine anyone wanting these to be overridden. Added api_filters to not cause extra warnings in the code.

From JUnitRemoteTestRunnerClient to RemoteTestRunnerClient, both in the same plugin.

- fixes #961

- fixes #174 - add logic to buildField to handle wildcard types - add new scenario to current test in CleanUpTest1d8

based on friends in jdt.core: eclipse-jdt/eclipse.jdt.core#1700

Contributes to eclipse-platform/eclipse.platform.releng.aggregator#1531

Refactor logic for javadoc html generation to jdt.core.manipulation Signed-off-by: Rob Stryker <[email protected]> Co-authored-by: Rob Stryker <[email protected]>

…() (#928) - fixes #876

* Refactor invert-equals quickfix for headless mode. * Fix copyright for new file to have single year --------- Co-authored-by: Jeff Johnston <[email protected]>

* Refactor lambda quickfixes for headless - ChangeLambdaBodyToBlock - ChangeLambdaBodyToExpression - ConvertLambdaToMethodReference - AddInferredLambdaParameterTypes - AddVarLambdaParameterTypes - RemoveVarOrInferredLambdaParameterTypes

Closing a ByteArrayInputStream has no effect

The class contains some tests that cover the current capabilities of JUnit5TestFinder and it was missing from the tests. This class does NOT resemble the other 2 existing classes: JUnit3TestFinder and JUnit4TestFinder

The test finder should be obtained by looking into the container and determining what kind of tests can be run there. Rename JUnit4TestFinderTest to JUnitTestFinderTest and make it a parameterized test that runs both in JUnit4 and JUnit5 mode and add a regression test to it ("testInnerClassWithNestedAnnotationIsFound") Fixes eclipse-jdt/eclipse.jdt.ui#952

…LTextReader

Fixes eclipse-jdt/eclipse.jdt.ui#1000

Improves performance of Call-Hierarchy, Type-Hierarchy, Hover, ... eclipse-jdt/eclipse.jdt.core#1614

beginTask must only be called once on a given progress monitor instance.

regression from "Performance: cache JARs during UI Operations" #933 During OpenAction arbitrary other events can be executed in swt thread during BusyIndicator.showWhile() partial revert of 763d4d0a4c1cc6d5809639ec356a7d499f4d9018

regression from "Performance: cache JARs during UI Operations" #933 During hover of problems sometimes a dummy quickfix is applied. partial revert of 763d4d0a4c1cc6d5809639ec356a7d499f4d9018

…#1009) The change fixes the conversion of an iterator based for loop to an enhanced for loop. When there is an iterator.next() in the body of the for loop and is a direct only child of the whole statement, it becomes a standalone identifier (var;) on conversion which is an errorful statement in Java. Fixes eclipse-jdt/eclipse.jdt.ui#1008

regression from "Performance: cache JARs during UI Operations" #933 During SelectionDispatchAction arbitrary other events can be executed in swt thread during BusyIndicator.showWhile() partial revert of 763d4d0a4c1cc6d5809639ec356a7d499f4d9018

…… (#1011) * Push down code related to java partition scanners, now that o.e.jface.text.rules have been moved to org.eclipse.text Signed-off-by: Rob Stryker <[email protected]>

See eclipse-jdt/eclipse.jdt.core#1394 See eclipse-platform/eclipse.platform.releng.aggregator#1659

See eclipse-platform/eclipse.platform.releng.aggregator#1661 See eclipse-platform/eclipse.platform.releng.aggregator#1659

…r Any Class #1013 The fix to check if the expression containing next as a method binding is the relevant iterator. Fixes eclipse-jdt/eclipse.jdt.ui#1013

To centralize many deprecation warnings, since there is no replacement for SUPPRESS_SUBTASK_LABEL/PREPEND_MAIN_LABEL_TO_SUBTASK

This change adjusts TestSuiteElement to show the trace of a failed child, if that child is the only test case it ran and its dynamic. It also adjusts navigation to the failed line in this case - so that navigation goes to the failed line and not to the test method with the @testtemplate annotation. Fixes: #1021 Signed-off-by: Simeon Andreev <[email protected]>

Fixes eclipse-jdt/eclipse.jdt.ui#1028

Fixes eclipse-jdt/eclipse.jdt.ui#1026

When exporting JAR description files from the JarPackageWizard, the elements to be exported into the JAR file are currently stored in a non-deterministic order. This makes it particularly difficult to merge the description files in case they are put under version control. This change makes a JAR description file exported from the JarPackageWizard always list the exported elements in the same order by sorting them according to their names. It also adds an according regression test. Fixes eclipse-jdt/eclipse.jdt.ui#1024

Read the contents of the java file (test class) as a stream to avoid FileNotFoundException in nightly builds. Fixes eclipse-jdt/eclipse.jdt.ui#999

…ts (#1037)

* Feature Proposal Make Static Refactoring Fixes #590 Introducing a new Refactoring called "Make Static", a tool that transforms instance methods into static ones in the context of Eclipse's Java Development Tools. This involves adjusting method invocations appropriately to maintain logical correctness. The refactoring supports both instance and static contexts, passing 'this' for invocations within instance methods and the relevant instance variable for invocations in other classes or static methods. Co-authored-by: Michael5601 <[email protected]> Co-authored-by: Jeff Johnston <[email protected]>

partially revert of fc6a25a eclipse-jdt/eclipse.jdt.ui#1051

- fixes #1023 - add new test to ExtractConstantTests1d7.java

…#1049)

To get rid of SubProgressMonitor deprecation warnings

…055) Signed-off-by: Kalyan Prasad Tatavarthi <[email protected]>

* refactor method-ref fixes to be used in headless mode.

- fixes #1040 - don't perform convert to MessageFormat.format() or String.format() unless all string literals have NLS tags or none do - add new tests to AssistQuickFixTest

fixes #1059

…(#1004) * Fix Bug 148012 - add quick fix to assign statement to local variable - see https://bugs.eclipse.org/bugs/show_bug.cgi?id=148012 - use similar logic from QuickAssistProcessor in QuickFixProcessor when problem is IProblem.ParsingErrorInsertToComplete - add new test to QuickFixTest1d8 - don't add light-bulb for ParsingErrorInsertToComplete - fix QuickFixTest to have a version of collect completions that doesn't verify the light bulb marker

…44 (#1072) The "Make Static" refactoring currently adds a "this" parameter to the method in cases in which it is actually not necessary. This is particularly the case the body of the method to be refactored contains invocations of methods on a newly instantiated object. The according logic erroneously considers such a method invocation as a reason to add a parameter. With this fix, the identification of whether a parameter needs to be added to the method depends on whether the logic calculating an actual change to the method body is actually applied. An according regression test for the behavior is added. Fixes eclipse-jdt/eclipse.jdt.ui#1044

…053) * A small pushdown of some classes jdt.ls would like to make use of Signed-off-by: Rob Stryker <[email protected]>

…070) * Avoid "overlapping text edits" in "Make Static" refactoring #1045 The "Make Static" refactoring currently produces overlapping text edits in case there are changes in the source code file containing the refactored method before and after that method. The reason is that the calls to the refactored method are wrapped into a single MultiTextEdit whose scope is then overlapping with the TextEdit for the refactored method itself. With this fix, the changes to callers of the refactored method are treated as individual TextEdits rather than one MultiTextEdit, so that none of the generated text edits have pairwise overlaps. An according regression test for the behavior is added. Fixes #1045

* Abstract out JavadocTagsSubProcessor for extension * Abstract out SerialVersionSubProcessor * Separate core from ui for UnInitializedFinalFieldSubProcessor * Allow all subprocessors to use IInvocationContextCore Signed-off-by: Rob Stryker <[email protected]> Co-authored-by: Rob Stryker <[email protected]>

* disabled warning in test and example code * raised level to warning in production code * refactored code to get rid of all warnings Co-authored-by: Jörg Kubitz <[email protected]>

* Push cleanup classes down to jdt.core.manipulations Signed-off-by: Rob Stryker <[email protected]>

fixes #1094

This change improves the Javadoc generation behavior of the "Make Static" refactoring and aligns it with other refactorings such as "Change Method Signature". It ensures that generated parameter tags are inserted at proper positions within an existing Javadoc comment. The tag for the parameter itself is added as the first parameter tag, following any author or version tags. The tags for potential type parameters are added as the last parameter tags, preceding any other tags than author or version. The reused functionality from ChangeMethodSignatureRefactoringContribution is factored out to the JavadocUtil class. Fixes eclipse-jdt/eclipse.jdt.ui#1043

- fixes #1096

…3 (#1085) The "Make Static" refactoring erroneously interprets a method call within an anonymous class inside the refactored method as a call on `this` and thus changes the method invocation to be performed on the added input parameter of the method. This is (1) semantically incorrect and (2) leads to compile errors if the type of the added parameter does not provide the method. With this fix, the identification of whether a method invocation is performed on the `this` object of the method to be refactored and not some instance of an anonymous inner class inside that method is corrected. For three different scenarios (anonymous class extending outer class, anonymous class extending other class, and nested anonymous classes), regression tests are added. Fixes eclipse-jdt/eclipse.jdt.ui#1083

eclipse-jdt/eclipse.jdt.ui#1098

eliminates problem markers and dead code

to get rid of "is not used" problem markers

* Fix String concat to text block to properly handle spaces - fixes #1111 - add new tests to AssistQuickFixTest15 - Fix CleanUpTest15 expected results

…gsWarningsSubProcessor (#1116) Signed-off-by: Rob Stryker <[email protected]> Co-authored-by: Rob Stryker <[email protected]>

In order to open a JAR file in multi-release mode the URL of the file must be suffixed with `#runtime`. Currently the `rsrc:` URL handler strips this fragment, which breaks multi-release JARs retrieved through the `rsrc:` protocol.

The other bundle might not be shutdown yet and would still want that key. Fixes eclipse-jdt/eclipse.jdt.ui#1093

See eclipse-platform/eclipse.platform.releng.aggregator#1750

eclipse-jdt/eclipse.jdt.ui#1131

eclipse-jdt/eclipse.jdt.ui#1132

…re.manipulation Signed-off-by: Hope Hadfield <[email protected]>

…(#1473)

- fixes #1123 - modify LocalCorrectionsSubProcessor.addInvalidVariableNameProposals() to recognize a duplicate constructor and instead of a rename suggest removal of duplicate constructor - add new test to LocalCorrectionsQuickFixTest.java

- fixes #915 - add wildcard support to ComparingOnCriteriaOperation.buildMethod() similar to what was added to buildField() - add to existing test case in CleanUpTest1d8 for comparator cleanup

* Split core/ui for ReorgCorrectionsSubProcessor * Separate core/ui in TypeMismatchSubProcessor * Split core/ui for ReturnTypeSubProcessor * Heavy work on UnresolvedElementsSubProcessor and linked classes * Update api filters Signed-off-by: Rob Stryker <[email protected]>

for example eclipse-jdt/eclipse.jdt.ui#230

…h no return type (#1142) Signed-off-by: Rob Stryker <[email protected]> Co-authored-by: Rob Stryker <[email protected]>

Signed-off-by: Rob Stryker <[email protected]> Co-authored-by: Rob Stryker <[email protected]>

to use public API instead of type cast. Failing since I20240130-1800 Java nature and java project are now implemented as separate instances eclipse-jdt/eclipse.jdt.core#1916

CleanUpOptions @noextend is not intended to be subclassed by CLIENTS.

tested with System.gc() behind ExtractInterfaceTests1d8.testExtractInterfaceFromInterface2()

- add missing synchronization for getCurrentChange() which accesses fChange which is created in a synchronized method - potential fix for #1136

The type ThreadDeath has been deprecated since version 20 and marked for removal

The method createImage(ImageDescriptor) from the type ResourceManager is deprecated since version 3.31

* Move some core code into ReorgCorrectionBaseSubProcessor Signed-off-by: Rob Stryker <[email protected]>

There is no plan to change the implementation

eclipse-jdt/eclipse.jdt.ui#1169

see eclipse-pde/eclipse.pde#1108

- fixes #963 - add new test to CleanUpTest1d8

See eclipse-platform/eclipse.platform.releng.aggregator#1781

…d IProblemLocationCore) - Removal of internal interfaces IInvocationContextCore and IProblemLocationCore Signed-off-by: Rob Stryker <[email protected]>

…ed (#1177) * Add checking so no invalid extract local variable proposals are offered - fix ExtractTempRefactoring.checkFinalConditions() to recognize an empty edit and set refactoring status to info with failure message - also fix the method to register it has been run and to save the refactoring status code - fix QuickAssistProcessor.getExtractVariableProposal() to run the checkFinalConditions() method of the extract temp refactorings and to not offer a proposal if the status is not OK - add new tests to ExtractTempTests and AssistQuickFixTest

- Remove internal interface ICleanUpCore - Remove CleanUpFixWrapper, as it is no longer necessary - Remove unused CleanUpCoreWrapper Signed-off-by: Rob Stryker <[email protected]>

…iFixCore Signed-off-by: Rob Stryker <[email protected]>

… (#1182) * Don't offer extract to constant unless expression is final and static - fixes #1180 - add new logic to QuickAssistProcessor.getExtractVariableProposal() - add new tests to AssistQuickFixTest

…xCore) - Delete internal interface IMultiFixCore & ILinkedFixCore, plus small cleanup Signed-off-by: Rob Stryker <[email protected]>

* Fix UI freeze due to extract to local computations - fixes #1185 - don't run checkFinalConditions() from QuickAssistProcessor to see if extract to local variable proposals are valid - override the preview for extract to local variable and extract to local variable (replace all occurrences) so they just display a message instead of creating the change - fix ExtractTempRefactoring.checkFinalConditions() to recognize an invalid change in which case add a fatal error status with a code from RefactoringStatusCodes - modify RefactoringCorrectionProposalCore to recognize the error and create a dummy edit plus a log entry to note that the extraction will not occur - fix AssistQuickFixTest tests proposal counts

* use concurrent datastructures, volatile fConflict * do not spinloop burning cpu Co-authored-by: Jörg Kubitz <[email protected]>

Commits on Feb 13, 2024

Create codeql.yml

jukzi authored and EcljpseB0T committed Feb 13, 2024

Configuration menu

View commit details

Copy full SHA for 72ece94

Browse repository at this point

Copy the full SHA

72ece94 View commit details

Browse the repository at this point in the history

Create codeql.yml #526

Create codeql.yml #526

Commits on Sep 6, 2023

Commits on Sep 8, 2023

Commits on Sep 11, 2023

Commits on Sep 12, 2023

Commits on Sep 13, 2023

Commits on Sep 14, 2023

Commits on Sep 15, 2023

Commits on Sep 16, 2023

Commits on Sep 17, 2023

Commits on Sep 18, 2023

Commits on Sep 19, 2023

Commits on Sep 20, 2023

Commits on Sep 21, 2023

Commits on Sep 22, 2023

Commits on Sep 25, 2023

Commits on Sep 26, 2023

Commits on Sep 27, 2023

Commits on Sep 28, 2023

Commits on Oct 3, 2023

Commits on Oct 4, 2023

Commits on Oct 5, 2023

Commits on Oct 6, 2023

Commits on Oct 10, 2023

Commits on Oct 11, 2023

Commits on Oct 13, 2023

Commits on Oct 16, 2023

Commits on Oct 17, 2023

Commits on Oct 19, 2023

Commits on Oct 20, 2023

Commits on Oct 23, 2023

Commits on Oct 25, 2023

Commits on Oct 26, 2023

Commits on Oct 27, 2023

Commits on Nov 1, 2023

Commits on Nov 2, 2023

Commits on Nov 3, 2023

Commits on Nov 4, 2023

Commits on Nov 6, 2023

Commits on Nov 15, 2023

Commits on Nov 27, 2023

Commits on Nov 28, 2023

Commits on Nov 29, 2023

Commits on Nov 30, 2023

Commits on Dec 1, 2023

Commits on Dec 3, 2023

Commits on Dec 4, 2023

Commits on Dec 5, 2023

Commits on Dec 6, 2023

Commits on Dec 7, 2023

Commits on Dec 8, 2023

Commits on Dec 11, 2023

Commits on Dec 12, 2023

Commits on Dec 13, 2023

Commits on Dec 14, 2023

Commits on Dec 15, 2023

Commits on Dec 16, 2023

Commits on Dec 18, 2023

Commits on Dec 21, 2023

Commits on Jan 2, 2024

Commits on Jan 3, 2024

Commits on Jan 4, 2024

Commits on Jan 8, 2024

Commits on Jan 9, 2024

Commits on Jan 10, 2024

Commits on Jan 11, 2024

Commits on Jan 12, 2024

Commits on Jan 14, 2024

Commits on Jan 16, 2024

Commits on Jan 17, 2024

Commits on Jan 18, 2024

Commits on Jan 19, 2024

Commits on Jan 22, 2024

Commits on Jan 23, 2024

Commits on Jan 24, 2024

Commits on Jan 25, 2024

Commits on Jan 26, 2024

Commits on Jan 29, 2024

Commits on Jan 30, 2024