-
Notifications
You must be signed in to change notification settings - Fork 135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make new GTK4 Dialog dynamic loaded for pre GTK 4.10 #1519
Make new GTK4 Dialog dynamic loaded for pre GTK 4.10 #1519
Conversation
1843062
to
c6f2bc0
Compare
c6f2bc0
to
940f5f1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm giving it +1 as it will allow compiling on 4.8 (as debian stable has) although runtime requirement will be 4.10+. Having newer than that build requirement is not feasible as it will introduce even newer glibc and etc. .
940f5f1
to
49a1124
Compare
Let's merge this one to allow compiling on debian image. We may need to bump eclipse.platform.swt/bundles/org.eclipse.swt/Eclipse SWT/gtk/org/eclipse/swt/widgets/Display.java Line 526 in e329edc
|
Apologies for the late response. Generally, I agree with @akurtakov. I don't think the current GTK4 port is anywhere near a productive state and by the time it becomes stable, the bottom line of 4.10 will already be quite old. This doesn't mean that we should always use the latest API, but at least for something that affects the UI like the dialogs, I believe that it is less of a headache to migrate it now, before it becomes widely used. And when GTK4 becomes the default backend, I doubt that SWT will immediately drop GTK3, leaving it as an usable alternative for older platforms, at least for a few more releases. |
This is a draft to make the GTK4.10 dialog compile with older GTK versions
FYI @ptziegler @akurtakov
this is not complete but in case someone wants to pick it up I wanted to share my progress here, with this changes it actually compiles again now.