fix: Remove instanceof comparison for MongoDB DB instance check #112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We can not reasonably use an `instanceof` comparison to confirm that a given object is of type MongoDB since we may be using a different version of MongoDB than what a caller might be using. In this scenario the check would fail. Thus this patch checks if a required field in the IDbProperties object is set. This required field is not a known field in MongoDB instance, thus it is arguably sane to check it in this manner.
stieg
force-pushed
the
r/stieg/instanceof-fix
branch
from
171b358
to
20cc7d0
Compare
| } else { | ||
| const options = { ...this.options.db.options }; | ||
|
|
||
| // Check if connectionUrl exists. If it does, assume its IDbProperties object |
There was a problem hiding this comment.
Per discussion with @stieg, one solution is to make MongoDB a devDependency making it so the logic uses the consumer's own MongoDB package.
emmanuelbuah
approved these changes
Feb 12, 2020
|
Is a new release coming soon? I am working around it by specifying |
|
Merging this for now. Will put in place a better solution (traced by #148) to address the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We can not reasonably use an
instanceofcomparison to confirm that agiven object is of type MongoDB since we may be using a different
version of MongoDB than what a caller might be using. In this
scenario the check would fail. Thus this patch checks if a required
field in the IDbProperties object is set. This required field is not a
known field in MongoDB instance, thus it is arguably sane to check it
in this manner.