Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Remove instanceof comparison for MongoDB DB instance check #112

Merged
merged 1 commit into from
Apr 16, 2020
Merged

fix: Remove instanceof comparison for MongoDB DB instance check #112

merged 1 commit into from
Apr 16, 2020

Commits on Feb 12, 2020

  1. fix: Remove instanceof comparison for MongoDB DB instance check 

    We can not reasonably use an `instanceof` comparison to confirm that a
given object is of type MongoDB since we may be using a different
version of MongoDB than what a caller might be using.  In this
scenario the check would fail. Thus this patch checks if a required
field in the IDbProperties object is set. This required field is not a
known field in MongoDB instance, thus it is arguably sane to check it
in this manner.
    @stieg
    stieg committed Feb 12, 2020
    Configuration menu
    Copy the full SHA
    20cc7d0 View commit details
    Browse the repository at this point in the history