Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[eas-cli] remove @expo/config-types dependency #2528

Merged
merged 1 commit into from
Oct 17, 2024

Conversation

szdziedzic
Copy link
Member

@szdziedzic szdziedzic commented Sep 2, 2024

Why

Rely on ExpoConfig type from the @expo/config package in all places for consistency

How

Rely on ExpoConfig type from the @expo/config package in all places for consistency

Test Plan

Tests

Copy link

github-actions bot commented Sep 2, 2024

Size Change: -879 B (0%)

Total Size: 52.9 MB

Filename Size Change
./packages/eas-cli/dist/eas-linux-x64.tar.gz 52.9 MB -879 B (0%)

compressed-size-action

Copy link

codecov bot commented Sep 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 53.09%. Comparing base (a7c77e8) to head (016c941).
Report is 4 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2528   +/-   ##
=======================================
  Coverage   53.09%   53.09%           
=======================================
  Files         563      563           
  Lines       21399    21399           
  Branches     4162     4162           
=======================================
  Hits        11360    11360           
  Misses      10010    10010           
  Partials       29       29           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@szdziedzic szdziedzic changed the title [eas-cli] remove @expo-config-types dependency [eas-cli] remove @expo/config-types dependency Sep 2, 2024
@szdziedzic szdziedzic force-pushed the 09-02-_eas-cli_remove_expo-config-types_dependency branch from 82304e9 to 016c941 Compare October 14, 2024 11:35
Copy link

❌ It looks like a changelog entry is missing for this PR. Add it manually to CHANGELOG.md.
⏩ If this PR doesn't require a changelog entry, such as if it's an internal change that doesn't affect the user experience, you can add the "no changelog" label to the PR.

Copy link

CodeMention:

File Patterns Mentions
**/* @szdziedzic, @khamilowicz, @sjchmiela
packages/eas-cli/src/build/** @szdziedzic, @khamilowicz, @sjchmiela
packages/eas-cli/src/update/** @EvanBacon, @byCedric, @wschurman
packages/eas-cli/src/metadata/** @byCedric

@szdziedzic szdziedzic merged commit 2dbaed5 into main Oct 17, 2024
10 of 11 checks passed
@szdziedzic szdziedzic deleted the 09-02-_eas-cli_remove_expo-config-types_dependency branch October 17, 2024 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants