Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[eas-cli] update expo packages to SDK 51 versions #2530

Open
wants to merge 1 commit into
base: 09-02-_eas-cli_use_getconfig_from_projectdir_node_modules__expo_config_if_available
Choose a base branch
from

Conversation

szdziedzic
Copy link
Member

@szdziedzic szdziedzic commented Sep 2, 2024

Why

update expo packages to SDK 51 versions

revert #2524

How

update expo packages to SDK 51 versions

Test Plan

tests

Copy link
Member Author

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @szdziedzic and the rest of your teammates on Graphite Graphite

Copy link

github-actions bot commented Sep 2, 2024

Size Change: -242 kB (-0.46%)

Total Size: 52.7 MB

Filename Size Change
./packages/eas-cli/dist/eas-linux-x64.tar.gz 52.7 MB -242 kB (-0.46%)

compressed-size-action

@szdziedzic szdziedzic changed the title [eas-cli] update @expo packages versions [eas-cli] update expo packages to SDK 51 versions Sep 2, 2024
@szdziedzic szdziedzic marked this pull request as ready for review September 2, 2024 16:31
@szdziedzic szdziedzic force-pushed the 09-02-_eas-cli_update_expo_packages_versions branch from ad28019 to 28c6181 Compare September 2, 2024 16:43
Copy link
Contributor

@radoslawkrzemien radoslawkrzemien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM once the failing tests are resolved

Copy link
Member

@wschurman wschurman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Double check test failures before landing.

@szdziedzic szdziedzic force-pushed the 09-02-_eas-cli_use_getconfig_from_projectdir_node_modules__expo_config_if_available branch from b5f49ac to 9cd41f7 Compare October 14, 2024 11:35
@szdziedzic szdziedzic force-pushed the 09-02-_eas-cli_update_expo_packages_versions branch from 28c6181 to 32b6ffa Compare October 14, 2024 11:35
Copy link

CodeMention:

File Patterns Mentions
**/* @szdziedzic, @khamilowicz, @sjchmiela

@szdziedzic szdziedzic force-pushed the 09-02-_eas-cli_update_expo_packages_versions branch 3 times, most recently from e5b2666 to c72bac0 Compare October 15, 2024 08:28
Copy link

codecov bot commented Oct 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 53.10%. Comparing base (8536a7a) to head (37edc6d).

Additional details and impacted files
@@                                                 Coverage Diff                                                  @@
##           09-02-_eas-cli_use_getconfig_from_projectdir_node_modules__expo_config_if_available    #2530   +/-   ##
====================================================================================================================
  Coverage                                                                                53.10%   53.10%           
====================================================================================================================
  Files                                                                                      564      564           
  Lines                                                                                    21508    21508           
  Branches                                                                                  4207     4207           
====================================================================================================================
  Hits                                                                                     11420    11420           
  Misses                                                                                   10058    10058           
  Partials                                                                                    30       30           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@szdziedzic szdziedzic force-pushed the 09-02-_eas-cli_use_getconfig_from_projectdir_node_modules__expo_config_if_available branch 2 times, most recently from da4d277 to 8536a7a Compare October 17, 2024 12:57
@szdziedzic szdziedzic force-pushed the 09-02-_eas-cli_update_expo_packages_versions branch from c72bac0 to 37edc6d Compare October 17, 2024 12:57
Copy link

❌ It looks like a changelog entry is missing for this PR. Add it manually to CHANGELOG.md.
⏩ If this PR doesn't require a changelog entry, such as if it's an internal change that doesn't affect the user experience, you can add the "no changelog" label to the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants