Typo nits #11
Open
Typo nits #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JoftheV
approved these changes
May 23, 2024
| @@ -40,7 +40,7 @@ Mozilla's and Chrome's match the spec on mobile | |||
| but on desktop they both give priority to running `unload` handlers | |||
| and block BFCache if an `unload` handler is present. | |||
| In Chrome's case we felt that since it was already unreliable on mobile | |||
| that making it moreso was not a problem. | |||
| that making it more so was not a problem. | |||
There was a problem hiding this comment.
There's a missing space after the period in this sentence.
-43:that making it more so was not a problem.
+43: that making it more so was not a problem.| @@ -360,7 +360,7 @@ Permissions-Policy-Report-Only: unload=() | |||
|
|
|||
| ``` | |||
|
|
|||
| You must also supply the correct ReportingAPI headers e.g. | |||
| You must also supply the correct Reporting API headers e.g. | |||
There was a problem hiding this comment.
Typo in URL example, 'exmaple.com' should be 'example.com'.
-Report-To: {"group":"default","max_age":1800,"endpoints":[{"url":"https://exmaple.com/report"}],"include_subdomains":true}
+Report-To: {"group":"default","max_age":1800,"endpoints":[{"url":"https://example.com/report"}],"include_subdomains":true}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.