Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typo nits #11

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions explainers/permissions-policy-deprecate-unload.md
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ Mozilla's and Chrome's match the spec on mobile
but on desktop they both give priority to running `unload` handlers
and block BFCache if an `unload` handler is present.
In Chrome's case we felt that since it was already unreliable on mobile
that making it moreso was not a problem.
that making it more so was not a problem.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a missing space after the period in this sentence.

-43:that making it more so was not a problem.
+43: that making it more so was not a problem.

However with 95% reliability on desktop,
reducing that significantly would be a problem.

Expand Down Expand Up @@ -349,9 +349,9 @@ You should see
[Violation] Permissions policy violation: unload is not allowed in this document.
```

## Using ReportingAPI to find unloads
## Using Reporting API to find unloads

You can use the [ReportintAPI](https://www.w3.org/TR/reporting-1/)
You can use the [Reporting API](https://www.w3.org/TR/reporting-1/)
to detect uses of unload in your pages
without preventing the usage. E.g.

Expand All @@ -360,7 +360,7 @@ Permissions-Policy-Report-Only: unload=()

```

You must also supply the correct ReportingAPI headers e.g.
You must also supply the correct Reporting API headers e.g.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo in URL example, 'exmaple.com' should be 'example.com'.

-Report-To: {"group":"default","max_age":1800,"endpoints":[{"url":"https://exmaple.com/report"}],"include_subdomains":true}
+Report-To: {"group":"default","max_age":1800,"endpoints":[{"url":"https://example.com/report"}],"include_subdomains":true}


```
Report-To: {"group":"default","max_age":1800,"endpoints":[{"url":"https://exmaple.com/report"}],"include_subdomains":true}
Expand Down