Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ottrfy the references #13

Merged
merged 4 commits into from
Feb 1, 2024
Merged

ottrfy the references #13

merged 4 commits into from
Feb 1, 2024

Conversation

kweav
Copy link
Contributor

@kweav kweav commented Feb 1, 2024

Purpose/implementation Section

What changes are being implemented in this Pull Request?

Moving the references from superscripts and a corresponding reference section to be ottr-fied

What was your approach?

Followed the instructions in the OTTR documentation

  • Add references in book.bib
  • replace the superscript with a call to the reference ([@key])
  • removing the reference section in Chapter 1
  • adding References.Rmd in _bookdown.yml after About.Rmd
  • and editing _output.yml to include split_bib: false

What GitHub issue does your pull request address?

Issue #8, specifically from the comments, using OTTR to incorporate references, rather than the superscripting and manual section that was there

@kweav kweav requested a review from avahoffman February 1, 2024 16:55
Copy link
Contributor

github-actions bot commented Feb 1, 2024

No broken urls! 🎉
Comment updated at 2024-02-01 with changes from a3ccec9

Copy link
Contributor

github-actions bot commented Feb 1, 2024

No spelling errors! 🎉
Comment updated at 2024-02-01 with changes from a3ccec9

Copy link
Contributor

github-actions bot commented Feb 1, 2024

Re-rendered previews from the latest commit:

Updated at 2024-02-01 with changes from a3ccec9

@avahoffman avahoffman mentioned this pull request Feb 1, 2024
Copy link
Contributor

@avahoffman avahoffman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

book.bib Outdated Show resolved Hide resolved
Co-authored-by: AM Hoffman <[email protected]>
@kweav kweav merged commit 3bb88e3 into main Feb 1, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants