Some updates related to dualspace #39
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dham
reviewed
Jul 19, 2023
ReubenHill
reviewed
Jul 19, 2023
ReubenHill
reviewed
Jul 19, 2023
dham
reviewed
Jul 19, 2023
| self.original_form = form | ||
|
|
||
| # --- Pass form integrands through some symbolic manipulation | ||
| def preprocess_form(form, complex_mode): | ||
|
|
||
| # Note: Default behaviour here will process form the way that is | ||
| # currently expected by vanilla FFC |
There was a problem hiding this comment.
This comment should be on compute_form_data
| self.original_form = form | ||
|
|
||
| # --- Pass form integrands through some symbolic manipulation | ||
| def preprocess_form(form, complex_mode): |
ufl/differentiation.py
Outdated
| base_form_args = base_form.arguments() + tuple(arg for a in arguments for arg in extract_arguments(a)) | ||
| base_form_coeffs = base_form.coefficients() + tuple(arg for a in arguments for arg in extract_coefficients(a)) | ||
| self._arguments = tuple(OrderedDict.fromkeys(base_form_args)) | ||
| self._coefficients = tuple(OrderedDict.fromkeys(base_form_coeffs)) |
* [feature][ElementTypes] Added 4d types pentatope (4d simplex) and tesseract (4d cube). (FEniCS#95) Co-authored-by: Jack S. Hale <[email protected]> Co-authored-by: David A. Ham <[email protected]> Co-authored-by: Matthew Scroggs <[email protected]> * fix merge, add test --------- Co-authored-by: dr-robertk <[email protected]> Co-authored-by: Jack S. Hale <[email protected]> Co-authored-by: David A. Ham <[email protected]>
* removed probably unneeded troublesome lines in VectorElement The removed code overwrites some properties for whatever reason, in particular, quad_scheme. In TensorElement these two lines were not there at all. * added back FiniteElementBase constructor but (re)use sub-element data properly Note: the call to FiniteElementBase.__init__ overrides some properties set by the MixedElement constructor. Essentially the same seems to be done in TensorElement, but more explicitly. --------- Co-authored-by: rambausek <[email protected]> Co-authored-by: Jørgen Schartum Dokken <[email protected]> Co-authored-by: Matthew Scroggs <[email protected]>
* Add function determinant_expr_nxn * Change the order of the assert expression --------- Co-authored-by: Matthew Scroggs <[email protected]>
…ng coefficient derivative maps (FEniCS#124) * A possible fix for taking the derivative of vector coefficients w.r.t. a scalar. Also adding a test. * A slightly neater version that handles scalar derivatives of vectors. --------- Co-authored-by: Matthew Scroggs <[email protected]>
* return correct Sobolev space for FacetElement * InteriorElement in L2 --------- Co-authored-by: Matthew Scroggs <[email protected]>
* Change perp to being a named operator * PR FEniCS#184: fix behaviour when perp is Zero and expand testing --------- Co-authored-by: Matthew Scroggs <[email protected]>
Co-authored-by: Matthew Scroggs <[email protected]>
* Add trimmed serendipity * Fix value shape for trimmed serendipity * ufl plumbing update for trimmed serendipity. * Plumbing for SminusDiv.py * Adding in element stuff for SminusCurl. * Fix typo * remove spurioius names --------- Co-authored-by: Rob Kirby <[email protected]> Co-authored-by: Justincrum <[email protected]> Co-authored-by: nbouziani <[email protected]> Co-authored-by: ksagiyam <[email protected]> Co-authored-by: ksagiyam <[email protected]> Co-authored-by: Connor Ward <[email protected]>
--------- Co-authored-by: Igor Baratta <[email protected]> Co-authored-by: Matthew Scroggs <[email protected]> Co-authored-by: David A. Ham <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses a few issues related to the recent dual space changes in UFL (FEniCS#87).
The main changes are:
BaseFormobjects with acoefficientsslot.BaseFormobjects with aufl_domainas they can be differentiated, which requires inferring the underlying domain.Cofunctions now have one argument in the primal space as they map from V to R.Coarguments now have two arguments. In fact,Coarguments map from V* to V*, i.e. V* -> V*, or equivalently V* x V -> R, hence they have one argument in the primal space and one in the dual space.BaseFormCoordinateDerivativeand fix the argument analysis forBaseFormDerivativeobjects.Actiondifferentiation ruleAdjointdifferentiation