docs: Minor updates to steps 3 & 4 in Klondike tutorial #2626
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also update the first note around lazy loading so the reader still knows why its important to load the variables in a lazy way.
The DragCallbacks mixin contains its own version of the _isDragging flag called _isDragged (accessible via isDragged getter) so we don't need to keep a local flag to check for valid drags
spydon
changed the title
spydon
approved these changes
Jul 29, 2023
There was a problem hiding this comment.
Just some trailing spaces that needs to be removed, otherwise it looks good to me.
Thanks for your contribution!
doc/tutorials/klondike/step3.md:58:76 MD009/no-trailing-spaces Trailing spaces [Expected: 0 or 2; Actual: 1]
doc/tutorials/klondike/step3.md:59:76 MD009/no-trailing-spaces Trailing spaces [Expected: 0 or 2; Actual: 1]
doc/tutorials/klondike/step3.md:60:75 MD009/no-trailing-spaces Trailing spaces [Expected: 0 or 2; Actual: 1]
doc/tutorials/klondike/step3.md:61:76 MD009/no-trailing-spaces Trailing spaces [Expected: 0 or 2; Actual: 1]
doc/tutorials/klondike/step4.md:585:97 MD009/no-trailing-spaces Trailing spaces [Expected: 0 or 2; Actual: 1]
doc/tutorials/klondike/step4.md:586:94 MD009/no-trailing-spaces Trailing spaces [Expected: 0 or 2; Actual: 1]
|
@spydon Ah you beat me to it! I hadn't set up markdown linting on my fork yet sorry about that I'm pretty new to open source contributing, should be fixed now. Thanks for the fast review 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I have just finished steps 1-4 of the Klondike tutorial and noticed a couple of minor things that look to be outdated with the current dart / flame versions.
Step 3 -
latekeyword isn't requiredWhen following this step the analyser hightlight this rule unnecessary_late (introduced in Dart 2.16.0) which states:
I updated the notes around why the laziness is important so the reader can still understand the reasoning.
Step 4 - local
_isDraggingvsDragCallbacks.isDraggedLooking through the
DragCallbacksmixin I found thatonDragStart()andonDragEnd()both set a private_isDraggedflag that acts the same as the_isDragginglocal flag created in the tutorial. This was added in #2472 along with@mustCallSuperannotations on both methods.So this change brings the docs up to date by having the new
onDragStart/onDragEndmethods reference theirsuper'ssuper.onDragStartandsuper.onDragEndinstead of the local flag, and nowonDragUpdate,onDragEnduseif (!isDragged) { .. }instead ofif (!_isDragging) { .. }.Thanks for awesome tutorial! It's really well written and explains everything just as you need it without being overwhelming.
Checklist
docsand added dartdoc comments with///.examplesordocs.Breaking Change?