Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: Minor updates to steps 3 & 4 in Klondike tutorial #2626

Merged
merged 4 commits into from
Jul 29, 2023
Merged

docs: Minor updates to steps 3 & 4 in Klondike tutorial #2626

merged 4 commits into from
Jul 29, 2023

Commits on Jul 29, 2023

  1. docs: Remove unnecessary late keywords 

    Also update the first note around lazy loading so the reader still knows why its important to load the variables in a lazy way.
    @gilescm
    gilescm committed Jul 29, 2023
    Configuration menu
    Copy the full SHA
    aa7d314 View commit details
    Browse the repository at this point in the history

  2. docs: Replace reference of local flag with internal Mixin flag 

    The DragCallbacks mixin contains its own version of the _isDragging flag called _isDragged (accessible via isDragged getter) so we don't need to keep a local flag to check for valid drags
    @gilescm
    gilescm committed Jul 29, 2023
    Configuration menu
    Copy the full SHA
    a39d04d View commit details
    Browse the repository at this point in the history

  3. Update notes on super.onDragStart/End

    @gilescm
    gilescm committed Jul 29, 2023
    Configuration menu
    Copy the full SHA
    61e574b View commit details
    Browse the repository at this point in the history

  4. docs: fix trailing whitespaces

    @gilescm
    gilescm committed Jul 29, 2023
    Configuration menu
    Copy the full SHA
    ffb65cf View commit details
    Browse the repository at this point in the history