*Allow* periodic writes of the views to avoid loss of work when restarting #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Problem: as Dominic pointed out, flumedb is general purpose, so even if one write every 10K messages is a good compromise for ssb, it might be problematic for other projects. Solution: don't do periodic writes by default, but do allow passing a parameter to the module to set them up. Also I guess the periodic counter condition was inverted. :P
|
Love it, thanks @black-puppydog! |
This was referenced Jan 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the commit of #12, but with the count at which the view is persisted being an initialization-time parameter. I just tested that in patchwork and it works nicely
@christianbundy I hope this is less controversial than your PR? I'd love to just bump the version for this repo instead of including the code directly from my fork.