Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

*Allow* periodic writes of the views to avoid loss of work when restarting #16

Merged
merged 2 commits into from
Jan 11, 2021
Merged

*Allow* periodic writes of the views to avoid loss of work when restarting #16

merged 2 commits into from
Jan 11, 2021

Commits on Jan 10, 2021

  1. Add write every 10K messages

    @christianbundy @black-puppydog
    christianbundy authored and black-puppydog committed Jan 10, 2021
    Configuration menu
    Copy the full SHA
    10ac075 View commit details
    Browse the repository at this point in the history

  2. Make write interval a parameter. 

    Problem: as Dominic pointed out, flumedb is general purpose, so even if one write
every 10K messages is a good compromise for ssb, it might be problematic
for other projects.

Solution: don't do periodic writes by default, but do allow passing a
parameter to the module to set them up.

Also I guess the periodic counter condition was inverted. :P
    @black-puppydog
    black-puppydog committed Jan 10, 2021
    Configuration menu
    Copy the full SHA
    2ddf4bc View commit details
    Browse the repository at this point in the history