add pollingInterval, successfulJobsHistoryLimit, failedJobsHistory values #96
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bryfox
approved these changes
Sep 19, 2024
| # how many failed jobs to keep in Kubernetes history, this is a safe default, but may be lowered if desired. | ||
| failedJobsHistoryLimit: 100 | ||
| # how often to poll the autoscaling metric, this is a safe default | ||
| pollingInterval: 30 |
There was a problem hiding this comment.
Seconds, I assume? Can this support time strings like "30s" for maxWaitForWork above? If not, it would be nice to at least document the unit.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog
inbox-listener: for built-in autoscaling, add Helm chart values to tune
pollingInterval,successJobsHistoryLimitandfailedJobsHistoryLimitDocs
Description