Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add pollingInterval, successfulJobsHistoryLimit, failedJobsHistory values #96

Merged
merged 3 commits into from
Sep 19, 2024
Merged

add pollingInterval, successfulJobsHistoryLimit, failedJobsHistory values #96

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5d8639c
add pollingInterval, successfulJobsHistoryLimit, failedJobsHistory li…
sofuture Sep 19, 2024
9230461
bump primary-site version
sofuture Sep 19, 2024
a9f409f
update pollingInterval comment
sofuture Sep 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion charts/primary-site/Chart.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,6 @@ type: application
# 1.0.0-alpha.0
# 1.0.0-alpha.1
# 1.0.0
version: "0.0.47"
version: "0.0.48"

appVersion: "93273ddcd2bc95a010257dea19c97f9a8579a87b"
6 changes: 3 additions & 3 deletions charts/primary-site/templates/deployments/inbox-listener.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,9 +6,9 @@ metadata:
spec:
minReplicaCount: {{ .Values.inboxListener.autoscaling.minReplicas }}
maxReplicaCount: {{ .Values.inboxListener.autoscaling.maxReplicas }}
successfulJobsHistoryLimit: 50
failedJobsHistoryLimit: 100
pollingInterval: 30
successfulJobsHistoryLimit: {{ .Values.inboxListener.autoscaling.successfulJobsHistoryLimit }}
failedJobsHistoryLimit: {{ .Values.inboxListener.autoscaling.failedJobsHistoryLimit }}
pollingInterval: {{ .Values.inboxListener.autoscaling.pollingInterval }}
jobTargetRef:
parallelism: 1
activeDeadlineSeconds: 86400
Expand Down
7 changes: 7 additions & 0 deletions charts/primary-site/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,6 +113,13 @@ inboxListener:
# wait for new work items. It is unlikely that this value should be changed. The value should only be set when
# using this auto-scaling.
maxWaitForWork: "30s"
# how many successful jobs to keep in Kubernetes history, this is a safe default, but may be lowered if
# desired.
successfulJobsHistoryLimit: 50
# how many failed jobs to keep in Kubernetes history, this is a safe default, but may be lowered if desired.
failedJobsHistoryLimit: 100
# how often to poll the autoscaling metric, this is a safe default
pollingInterval: 30
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seconds, I assume? Can this support time strings like "30s" for maxWaitForWork above? If not, it would be nice to at least document the unit.


streamService:
service:
Expand Down
Loading