Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't fail if a service name cannot be looked up in LDAP #313

Merged
merged 1 commit into from
Nov 14, 2023

Conversation

rcritten
Copy link
Collaborator

A new method was introduced to handle more IPA services. This requires looking some of them up in LDAP. dirsrv not running was not being caught so raised an error instead.

Fixes: #312

A new method was introduced to handle more IPA services. This
requires looking some of them up in LDAP. dirsrv not running
was not being caught so raised an error instead.

Fixes: freeipa#312

Signed-off-by: Rob Crittenden <[email protected]>
@flo-renaud
Copy link
Contributor

Hi @rcritten
Thanks for the PR, works for me. Tested on fedora 39:

# systemctl stop [email protected]
# ipa-healthcheck --source ipahealthcheck.ipa.topology
Source 'ipahealthcheck.ipa.topology' is missing one or more requirements 'dirsrv'
# ipa-healthcheck --source ipahealthcheck.meta --check krb5kdc
Source 'ipahealthcheck.meta' is missing one or more requirements 'dirsrv'
# ipa-healthcheck
[
  {
    "source": "ipahealthcheck.meta.services",
    "check": "dirsrv",
    "result": "ERROR",
    "uuid": "dd8f25d7-6791-46ce-9a11-c60d2f4683e3",
    "when": "20231114084138Z",
    "duration": "0.008669",
    "kw": {
      "status": false,
      "msg": "dirsrv: not running"
    }
  }
]
# 

@rcritten rcritten merged commit 35ff773 into freeipa:master Nov 14, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The new method to get service names fails if dirsrv is down
2 participants