Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added cnv caller jumble #486

Merged
merged 21 commits into from
Sep 27, 2024
Merged

feat: added cnv caller jumble #486

merged 21 commits into from
Sep 27, 2024

Conversation

jonca79
Copy link
Collaborator

@jonca79 jonca79 commented Sep 6, 2024

This PR:

(If this is a release PR, no need to add following. Leave this part empty)
(Use the following lines to create a PR text body. Make sure to remove all non-relevant one after you're done)
(Repeat each field as many times as necessary)

Added: for new features.
Changed: for changes in existing functionality.
Deprecated: for soon-to-be removed features.
Removed: for now removed features.
Fixed: for any bug fixes.
Security: in case of vulnerabilities.

Review and tests:

  • Tests pass
  • If you've fixed a bug or added code that should be tested, add tests!
  • Code review
  • CHANGELOG.md is updated
  • New code is executed and covered by tests, and test approve

@jonca79 jonca79 marked this pull request as ready for review September 26, 2024 06:30
@jonca79 jonca79 requested a review from Smeds as a code owner September 26, 2024 06:30
config/config.yaml Outdated Show resolved Hide resolved
config/resources.yaml Outdated Show resolved Hide resolved
config/resources.yaml Outdated Show resolved Hide resolved
Copy link
Collaborator

@monikaBrandt monikaBrandt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good with the suggested updates.

@jonca79 jonca79 merged commit 684070d into develop Sep 27, 2024
8 of 10 checks passed
@jonca79 jonca79 deleted the jumble branch September 27, 2024 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants