Proposal to enhance eslint config, plus fixing current configuration

[MV88]

Description

I checked current config is broken and has never worked since 3 years!!!
check here the broken part https://github.com/geosolutions-it/MapStore2/blob/master/utility/eslint/index.js#L235

now we got
✖4095 problems (4095 errors, 0 warnings)
with --fix becomes
✖ 3869 problems (3869 errors, 0 warnings)

338 PropType is defined but prop is never used "react/no-unused-prop-types": 2
185 render should be placed after
3308 is missing in props validation "react/prop-types": [2, { "ignore": ["children"] }],

This PR is not mergiable because

• all the issues must be fixed unless we want to disable some and fix others
• we should revert the pointing to local utility/eslint index file and use a published one
• I would like to also add
  • "object-curly-spacing": [2, "never"] that has autofix
  • "comma-dangle": [ 2, "always-multiline" ], that has autofix

Please check if the PR fulfills these requirements

• The commit message follows our guidelines: https://github.com/geosolutions-it/MapStore2/blob/master/CONTRIBUTING.md
• Tests for the changes have been added (for bug fixes / features)
• Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (check one with "x", remove the others)

• Bugfix
• Feature
• Code style update (formatting, local variables)
• Refactoring (no functional changes, no api changes)
• Build related changes
• CI related changes
• Other... Please describe:

Issue

What is the current behavior?

#9190

What is the new behavior?

Breaking change

Does this PR introduce a breaking change? (check one with "x", remove the other)

• Yes, and I documented them in migration notes
• No

Other useful information

@offtherailz if you approve, please publish it since I cannot do that

[offtherailz]

This should not be committed, I think

[MV88]

of course, i did it so the action-build could have used the new config, it's also written in the PR description when i say PR is not mergiable

[tdipisa]

Thank you so much @MV88 for reporting this.

@offtherailz @MV88 @allyoucanmap @dsuren1
I think the typo should be corrected as soon as possible, possibly also in more than one step, since we have now lots of stratified errors reported due to this.

I think we could proceed by splitting this in two steps:

1. Manual fix of the following:
   338 PropType is defined but prop is never used "react/no-unused-prop-types": 2
   185 render should be placed after
2. Then fixing this:
   3308 is missing in props validation "react/prop-types": [2, { "ignore": ["children"] }],

We can continue using this PR by maintaining it in draft mode until all problems are solved. Can you please can you hear each other guys and give me an estimate for both points above?

[MV88]

@tdipisa

person	point 1	point 2
mv88	4h max	3 days

point 2 can be done slowly by updating the components when a new PR is created in mapstore

[tdipisa]

Closed in favore of #10006