-
Notifications
You must be signed in to change notification settings - Fork 373
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: move gnoland genesis
to contribs/gnogenesis
#3041
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3041 +/- ##
==========================================
- Coverage 63.37% 63.08% -0.29%
==========================================
Files 566 548 -18
Lines 79490 78514 -976
==========================================
- Hits 50374 49532 -842
+ Misses 25727 25634 -93
+ Partials 3389 3348 -41
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, Milos.
I don't think this command should be installed by default with We should keep the happy dev flow clean and minimal imho. |
You are more than welcome to open a PR that removes it from the "standard happy flow", and also improve tutorials on how this new binary can be used in development environments, if this is something in plan for the "gno developer roadmap". I've kept it easy to install to avoid shell headaches. We can remove it definitely in the future. |
Follow-up to #3041. Not even `gnoland` is part of the core commands in the root makefile, hence it makes no sense for `gnogenesis` to be one of them.
Description
This PR migrates the
gnoland genesis
command suite undercontribs/gnogenesis
, after following discussions from #2824, and internal discussions.BREAKING CHANGE
gnoland genesis
will cease to exist after this PR, instead, you will need to use the binary incontribs/gnogenesis
.It's installed by default after running
make install
from the repo root.Closes #2824
Contributors' checklist...
BREAKING CHANGE: xxx
message was included in the description