Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: move gnoland genesis to contribs/gnogenesis #3041

Merged
merged 8 commits into from
Oct 29, 2024

Conversation

zivkovicmilos
Copy link
Member

@zivkovicmilos zivkovicmilos commented Oct 28, 2024

Description

This PR migrates the gnoland genesis command suite under contribs/gnogenesis, after following discussions from #2824, and internal discussions.

BREAKING CHANGE
gnoland genesis will cease to exist after this PR, instead, you will need to use the binary in contribs/gnogenesis.
It's installed by default after running make install from the repo root.

Closes #2824

Contributors' checklist...
  • Added new tests, or not needed, or not feasible
  • Provided an example (e.g. screenshot) to aid review or the PR is self-explanatory
  • Updated the official documentation or not needed
  • No breaking changes were made, or a BREAKING CHANGE: xxx message was included in the description
  • Added references to related issues and PRs
  • Provided any useful hints for running manual tests

@zivkovicmilos zivkovicmilos added breaking change Functionality that contains breaking changes 📦 ⛰️ gno.land Issues or PRs gno.land package related labels Oct 28, 2024
@zivkovicmilos zivkovicmilos self-assigned this Oct 28, 2024
Copy link

codecov bot commented Oct 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.08%. Comparing base (d03581e) to head (e667e9c).
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3041      +/-   ##
==========================================
- Coverage   63.37%   63.08%   -0.29%     
==========================================
  Files         566      548      -18     
  Lines       79490    78514     -976     
==========================================
- Hits        50374    49532     -842     
+ Misses      25727    25634      -93     
+ Partials     3389     3348      -41     
Flag Coverage Δ
contribs/gnodev 60.57% <ø> (ø)
contribs/gnofaucet 14.82% <ø> (ø)
gno.land 63.82% <ø> (-3.56%) ⬇️
gnovm 67.87% <ø> (ø)
misc/genstd 79.72% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zivkovicmilos
Copy link
Member Author

zivkovicmilos commented Oct 28, 2024

Heads up @mazzy89 @r3v4s @sw360cab @albttx @D4ryl00

Copy link
Member

@moul moul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, Milos.

contribs/gnogenesis/go.mod Outdated Show resolved Hide resolved
docs/gno-infrastructure/validators/faq.md Outdated Show resolved Hide resolved
@leohhhn
Copy link
Contributor

leohhhn commented Oct 28, 2024

I don't think this command should be installed by default with make install. It doesn't fit in the standard Gnome dev flow; like gno, gnodev, gnokey do.

We should keep the happy dev flow clean and minimal imho.

@zivkovicmilos
Copy link
Member Author

@leohhhn

I don't think this command should be installed by default with make install. It doesn't fit in the standard Gnome dev flow like gno, gnodev, gnokey do.

We should keep the happy dev flow clean and minimal imho.

You are more than welcome to open a PR that removes it from the "standard happy flow", and also improve tutorials on how this new binary can be used in development environments, if this is something in plan for the "gno developer roadmap".
I haven't seen much research done to support these ideas, given we have a very limited developer base to begin with, and most of them are advanced users of the gnoland binary.

I've kept it easy to install to avoid shell headaches. We can remove it definitely in the future.
The PR doesn't even introduce a Docker image, which is something we also need (cc @sw360cab)

@zivkovicmilos zivkovicmilos merged commit 12bd8da into master Oct 29, 2024
126 checks passed
@zivkovicmilos zivkovicmilos deleted the dev/zivkovicmilos/genesis-contribs branch October 29, 2024 14:18
@Kouteki Kouteki added the in focus Core team is prioritizing this work label Oct 29, 2024
thehowl added a commit that referenced this pull request Oct 29, 2024
Follow-up to #3041.

Not even `gnoland` is part of the core commands in the root makefile,
hence it makes no sense for `gnogenesis` to be one of them.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking change Functionality that contains breaking changes in focus Core team is prioritizing this work 📦 ⛰️ gno.land Issues or PRs gno.land package related
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

feedback needed: how are you using gnoland genesis ...?
4 participants