Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Noto Serif TC #6695

Merged
merged 3 commits into from
Sep 14, 2023
Merged

Update Noto Serif TC #6695

merged 3 commits into from
Sep 14, 2023

Conversation

simoncozens
Copy link
Collaborator

@simoncozens simoncozens commented Sep 11, 2023

Closes #6534.

@simoncozens simoncozens added II CJK Chinese, Japanese, Korean scripts I Font Upgrade labels Sep 11, 2023
@github-actions
Copy link

FontBakery report

fontbakery version: 0.9.0a3

[1] Family checks
INFO: Check axis ordering on the STAT table. (com.google.fonts/check/STAT/axis_order)
  • INFO From a total of 1 font files, 0 of them (0.00%) lack a STAT table.

    And these are the most common STAT axis orderings:
    ('wght', 1) [code: summary]


[35] NotoSerifTC[wght].ttf
🔥 FAIL: Check Google Fonts glyph coverage. (com.google.fonts/check/glyph_coverage)
  • 🔥 FAIL Missing required codepoints:

    • 0x0308 (COMBINING DIAERESIS)

    • 0x030B (COMBINING DOUBLE ACUTE ACCENT)

    • 0x0104 (LATIN CAPITAL LETTER A WITH OGONEK)

    • 0x0106 (LATIN CAPITAL LETTER C WITH ACUTE)

    • 0x010C (LATIN CAPITAL LETTER C WITH CARON)

    • 0x010A (LATIN CAPITAL LETTER C WITH DOT ABOVE)

    • 0x010E (LATIN CAPITAL LETTER D WITH CARON)

    • 0x0116 (LATIN CAPITAL LETTER E WITH DOT ABOVE)

    • 0x0118 (LATIN CAPITAL LETTER E WITH OGONEK)

    • 0x011E (LATIN CAPITAL LETTER G WITH BREVE)

    • 93 more.

Use -F or --full-lists to disable shortening of long lists. [code: missing-codepoints]

🔥 FAIL: Check license file has good copyright string. (com.google.fonts/check/license/OFL_copyright)
  • 🔥 FAIL First line in license file is:

"copyright 2012 google inc. all rights reserved."

which does not match the expected format, similar to:

"Copyright 2022 The Familyname Project Authors (git url)" [code: bad-format]

🔥 FAIL: Check OFL body text is correct. (com.google.fonts/check/license/OFL_body_text)
🔥 FAIL: Ensure files are not too large. (com.google.fonts/check/file_size)
  • 🔥 FAIL Font file is 16.1Mb, larger than limit 9.0Mb [code: massive-font]
🔥 FAIL: Is the Grid-fitting and Scan-conversion Procedure ('gasp') table set to optimize rendering? (com.google.fonts/check/gasp)
  • 🔥 FAIL Font is missing the 'gasp' table. Try exporting the font with autohinting enabled.
    If you are dealing with an unhinted font, it can be fixed by running the fonts through the command 'gftools fix-nonhinting'
    GFTools is available at https://pypi.org/project/gftools/ [code: lacks-gasp]
🔥 FAIL: METADATA.pb font.full_name value matches fullname declared on the name table? (com.google.fonts/check/metadata/nameid/full_name)
  • 🔥 FAIL Unmatched fullname in font: TTF has "Noto Serif TC ExtraLight" while METADATA.pb has "Noto Serif TC". [code: mismatch]
🔥 FAIL: METADATA.pb font.full_name and font.post_script_name fields have equivalent values ? (com.google.fonts/check/metadata/match_fullname_postscript)
  • 🔥 FAIL METADATA.pb font full_name = "Noto Serif TC" does not match post_script_name = "NotoSerifTC-ExtraLight" [code: mismatch]
🔥 FAIL: METADATA.pb font.name field contains font name in right format? (com.google.fonts/check/metadata/valid_name_values)
  • 🔥 FAIL METADATA.pb font.name field ("Noto Serif TC") does not match correct font name format ("Noto Serif TC ExtraLight"). [code: mismatch]
🔥 FAIL: METADATA.pb font.full_name field contains font name in right format? (com.google.fonts/check/metadata/valid_full_name_values)
  • 🔥 FAIL METADATA.pb font.full_name field ("Noto Serif TC") does not match correct font name format ("Noto Serif TC ExtraLight"). [code: mismatch]
🔥 FAIL: Copyright notices match canonical pattern in METADATA.pb (com.google.fonts/check/metadata/valid_copyright)
  • 🔥 FAIL METADATA.pb: Copyright notices should match a pattern similar to:
    "Copyright 2020 The Familyname Project Authors (git url)"
    But instead we have got:
    "(c) 2017-2023 adobe (http://www.adobe.com/)." [code: bad-notice-format]
🔥 FAIL: Copyright notices match canonical pattern in fonts (com.google.fonts/check/font_copyright)
  • 🔥 FAIL Name Table entry: Copyright notices should match a pattern similar to: "Copyright 2019 The Familyname Project Authors (git url)"
    But instead we have got:
    "(c) 2017-2023 Adobe (http://www.adobe.com/)." [code: bad-notice-format]
🔥 FAIL: METADATA.pb font.name and font.full_name fields match the values declared on the name table? (com.google.fonts/check/metadata/nameid/family_and_full_names)
  • 🔥 FAIL METADATA.pb: Fullname "Noto Serif TC" does not match name table entry "Noto Serif TC ExtraLight"! [code: fullname-mismatch]
🔥 FAIL: METADATA.pb: Check URL on copyright string is the same as in repository_url field. (com.google.fonts/check/metadata/consistent_repo_urls)
  • 🔥 FAIL Value of repository_url field is

But font copyright string has: http://www.adobe.com/
[code: mismatch]

🔥 FAIL: Font enables smart dropout control in "prep" table instructions? (com.google.fonts/check/smart_dropout)
  • 🔥 FAIL The 'prep' table does not contain TrueType instructions enabling smart dropout control. To fix, export the font with autohinting enabled, or run ttfautohint on the font, or run the gftools fix-nonhinting script. [code: lacks-smart-dropout]
🔥 FAIL: Check samples can be rendered. (com.google.fonts/check/metadata/can_render_samples)
  • 🔥 FAIL Font can't render "yue_Hant" sample text:
    "鉴于对人权嘅无视同埋侮蔑经已发展成为野蛮暴行,呢些暴行玷污咗人类嘅良心,而一个人人都有言论同埋信仰自由而且冇惊冇穷嘅世界嘅嚟临"
    [code: sample-text]
  • WARN Aparently there's no sample strings for 'cjy_Hant' in the gflanguages package. [code: no-sample-string]
  • WARN Aparently there's no sample strings for 'gan_Hant' in the gflanguages package. [code: no-sample-string]
  • WARN Aparently there's no sample strings for 'hsn_Hant' in the gflanguages package. [code: no-sample-string]
  • WARN Aparently there's no sample strings for 'wuu_Hant' in the gflanguages package. [code: no-sample-string]
🔥 FAIL: Ensure dotted circle glyph is present and can attach marks. (com.google.fonts/check/dotted_circle)
  • 🔥 FAIL The following glyphs could not be attached to the dotted circle glyph:

    • acutecomb

    • gravecomb

    • uni0307

    • uni030C [code: unattached-dotted-circle-marks]

WARN: Check for codepoints not covered by METADATA subsets. (com.google.fonts/check/metadata/unreachable_subsetting)
  • WARN The following codepoints supported by the font are not covered by
    any subsets defined in the font's metadata file, and will never
    be served. You can solve this by either manually adding additional
    subset declarations to METADATA.pb, or by editing the glyphset
    definitions.

  • U+02C7 CARON: try adding one of: canadian-aboriginal, yi, tifinagh

  • U+02D9 DOT ABOVE: try adding one of: canadian-aboriginal, yi

  • U+0307 COMBINING DOT ABOVE: try adding one of: malayalam, canadian-aboriginal, math, syriac, coptic, tai-le, old-permic, tifinagh

  • U+030C COMBINING CARON: try adding one of: cherokee, tai-le

  • U+0391 GREEK CAPITAL LETTER ALPHA: try adding one of: greek, math, elbasan

  • U+0392 GREEK CAPITAL LETTER BETA: try adding one of: greek, math, elbasan

  • U+0393 GREEK CAPITAL LETTER GAMMA: try adding one of: greek, math, elbasan

  • U+0394 GREEK CAPITAL LETTER DELTA: try adding one of: greek, math, elbasan

  • U+0395 GREEK CAPITAL LETTER EPSILON: try adding one of: greek, math, elbasan

  • U+0396 GREEK CAPITAL LETTER ZETA: try adding one of: greek, math, elbasan
    3606 more.

Use -F or --full-lists to disable shortening of long lists.

Or you can add the above codepoints to one of the subsets supported by the font: chinese-traditional, cyrillic, latin, latin-ext, menu, vietnamese [code: unreachable-subsetting]

WARN: License URL matches License text on name table? (com.google.fonts/check/name/license_url)
  • WARN Please consider using HTTPS URLs at name table entry [plat=3, enc=1, name=14] [code: http-in-license-info]
WARN: Are there caret positions declared for every ligature? (com.google.fonts/check/ligature_carets)
  • WARN This font lacks caret position values for ligature glyphs on its GDEF table. [code: lacks-caret-pos]
WARN: Is there kerning info for non-ligated sequences? (com.google.fonts/check/kerning_for_non_ligated_sequences)
  • WARN GPOS table lacks kerning info for the following non-ligated sequences:

    • f + f

    • f + i

    • i + f

    • f + l

    • l + f

    • i + l [code: lacks-kern-info]

WARN: Combined length of family and style must not exceed 27 characters. (com.google.fonts/check/name/family_and_style_max_length)
  • WARN The combined length of family and style exceeds 27 chars in the following 'WINDOWS' entries:
    FONT_FAMILY_NAME = 'Noto Serif TC ExtraLight' / SUBFAMILY_NAME = 'Regular'

Please take a look at the conversation at fonttools/fontbakery#2179 in order to understand the reasoning behind these name table records max-length criteria. [code: too-long]

WARN: A static fonts directory with at least two fonts must accompany variable fonts (com.google.fonts/check/repo/vf_has_static_fonts)
  • WARN Please consider adding a subdirectory called "static/" and including in it static font files. [code: missing]
WARN: Ensure fonts have ScriptLangTags declared on the 'meta' table. (com.google.fonts/check/meta/script_lang_tags)
  • WARN This font file does not have a 'meta' table. [code: lacks-meta-table]
WARN: Check font contains no unreachable glyphs (com.google.fonts/check/unreachable_glyphs)
  • WARN The following glyphs could not be reached by codepoint or substitution rules:

    • glyph00470

    • glyph00472

    • glyph00473

    • glyph00477

    • glyph00603

    • glyph01006

    • glyph01112

    • glyph01134

    • glyph01668

    • glyph01670

    • 96 more.

Use -F or --full-lists to disable shortening of long lists.
[code: unreachable-glyphs]

WARN: Does the font contain a soft hyphen? (com.google.fonts/check/soft_hyphen)
  • WARN This font has a 'Soft Hyphen' character. [code: softhyphen]
WARN: Does the font contain chws and vchw features? (com.google.fonts/check/cjk_chws_feature)
WARN: Check math signs have the same width. (com.google.fonts/check/math_signs_width)
  • WARN The most common width is 1000 among a set of 43 math glyphs.
    The following math glyphs have a different width, though:

Width = 571:
logicalnot, equal, minus, plus, less, greater
[code: width-outliers]

WARN: Font has correct post table version? (com.google.fonts/check/post_table_version)
  • WARN Post table format 3 use has niche use case problems.Please review the check rationale for additional details. [code: post-table-version]
WARN: Check mark characters are in GDEF mark glyph class. (com.google.fonts/check/gdef_mark_chars)
  • WARN The following mark characters could be in the GDEF mark glyph class:
    uni0304 (U+0304), uni20DD (U+20DD), uni20DE (U+20DE), uni302A (U+302A), uni302B (U+302B), uni302C (U+302C), uni302D (U+302D), uni3099 (U+3099) and uni309A (U+309A) [code: mark-chars]
INFO: Show hinting filesize impact. (com.google.fonts/check/hinting_impact)
  • INFO Hinting filesize impact:
ofl/notoseriftc/NotoSerifTC[wght].ttf
Dehinted Size 16.1Mb
Hinted Size 16.1Mb
Increase -24 bytes
Change -0.0 %
[code: size-impact]
INFO: Font has old ttfautohint applied? (com.google.fonts/check/old_ttfautohint)
  • INFO Could not detect which version of ttfautohint was used in this font. It is typically specified as a comment in the font version entries of the 'name' table. Such font version strings are currently: ['Version 2.002-H1;hotconv 1.1.0;makeotfexe 2.6.0'] [code: version-not-detected]
INFO: EPAR table present in font? (com.google.fonts/check/epar)
INFO: Check for font-v versioning. (com.google.fonts/check/fontv)
  • INFO Version string is: "Version 2.002-H1;hotconv 1.1.0;makeotfexe 2.6.0"
    The version string must ideally include a git commit hash and either a "dev" or a "release" suffix such as in the example below:
    "Version 1.3; git-0d08353-release" [code: bad-format]
INFO: Font contains all required tables? (com.google.fonts/check/required_tables)
  • INFO This font contains the following optional tables:

    • loca

    • BASE

    • GPOS

    • GSUB

    • vhea

    • vmtx [code: optional-tables]

INFO: List all superfamily filepaths (com.google.fonts/check/superfamily/list)
  • INFO ofl/notoseriftc [code: family-path]

Summary

💔 ERROR 🔥 FAIL ⚠ WARN 💤 SKIP ℹ INFO 🍞 PASS 🔎 DEBUG
0 16 13 51 7 162 0
0% 6% 5% 20% 3% 65% 0%

Note: The following loglevels were omitted in this report:

  • SKIP
  • PASS
  • DEBUG

@github-actions
Copy link

FontBakery report

fontbakery version: 0.9.0a3

[1] Family checks
INFO: Check axis ordering on the STAT table. (com.google.fonts/check/STAT/axis_order)
  • INFO From a total of 1 font files, 0 of them (0.00%) lack a STAT table.

    And these are the most common STAT axis orderings:
    ('wght', 1) [code: summary]


[34] NotoSerifTC[wght].ttf
🔥 FAIL: Check Google Fonts glyph coverage. (com.google.fonts/check/glyph_coverage)
  • 🔥 FAIL Missing required codepoints:

    • 0x0308 (COMBINING DIAERESIS)

    • 0x030B (COMBINING DOUBLE ACUTE ACCENT)

    • 0x0104 (LATIN CAPITAL LETTER A WITH OGONEK)

    • 0x0106 (LATIN CAPITAL LETTER C WITH ACUTE)

    • 0x010C (LATIN CAPITAL LETTER C WITH CARON)

    • 0x010A (LATIN CAPITAL LETTER C WITH DOT ABOVE)

    • 0x010E (LATIN CAPITAL LETTER D WITH CARON)

    • 0x0116 (LATIN CAPITAL LETTER E WITH DOT ABOVE)

    • 0x0118 (LATIN CAPITAL LETTER E WITH OGONEK)

    • 0x011E (LATIN CAPITAL LETTER G WITH BREVE)

    • 93 more.

Use -F or --full-lists to disable shortening of long lists. [code: missing-codepoints]

🔥 FAIL: Check license file has good copyright string. (com.google.fonts/check/license/OFL_copyright)
  • 🔥 FAIL First line in license file is:

"copyright 2012 google inc. all rights reserved."

which does not match the expected format, similar to:

"Copyright 2022 The Familyname Project Authors (git url)" [code: bad-format]

🔥 FAIL: Check OFL body text is correct. (com.google.fonts/check/license/OFL_body_text)
🔥 FAIL: Ensure files are not too large. (com.google.fonts/check/file_size)
  • 🔥 FAIL Font file is 16.1Mb, larger than limit 9.0Mb [code: massive-font]
🔥 FAIL: METADATA.pb font.full_name value matches fullname declared on the name table? (com.google.fonts/check/metadata/nameid/full_name)
  • 🔥 FAIL Unmatched fullname in font: TTF has "Noto Serif TC ExtraLight" while METADATA.pb has "Noto Serif TC". [code: mismatch]
🔥 FAIL: METADATA.pb font.full_name and font.post_script_name fields have equivalent values ? (com.google.fonts/check/metadata/match_fullname_postscript)
  • 🔥 FAIL METADATA.pb font full_name = "Noto Serif TC" does not match post_script_name = "NotoSerifTC-ExtraLight" [code: mismatch]
🔥 FAIL: METADATA.pb font.name field contains font name in right format? (com.google.fonts/check/metadata/valid_name_values)
  • 🔥 FAIL METADATA.pb font.name field ("Noto Serif TC") does not match correct font name format ("Noto Serif TC ExtraLight"). [code: mismatch]
🔥 FAIL: METADATA.pb font.full_name field contains font name in right format? (com.google.fonts/check/metadata/valid_full_name_values)
  • 🔥 FAIL METADATA.pb font.full_name field ("Noto Serif TC") does not match correct font name format ("Noto Serif TC ExtraLight"). [code: mismatch]
🔥 FAIL: Copyright notices match canonical pattern in METADATA.pb (com.google.fonts/check/metadata/valid_copyright)
  • 🔥 FAIL METADATA.pb: Copyright notices should match a pattern similar to:
    "Copyright 2020 The Familyname Project Authors (git url)"
    But instead we have got:
    "(c) 2017-2023 adobe (http://www.adobe.com/)." [code: bad-notice-format]
🔥 FAIL: Copyright notices match canonical pattern in fonts (com.google.fonts/check/font_copyright)
  • 🔥 FAIL Name Table entry: Copyright notices should match a pattern similar to: "Copyright 2019 The Familyname Project Authors (git url)"
    But instead we have got:
    "(c) 2017-2023 Adobe (http://www.adobe.com/)." [code: bad-notice-format]
🔥 FAIL: METADATA.pb font.name and font.full_name fields match the values declared on the name table? (com.google.fonts/check/metadata/nameid/family_and_full_names)
  • 🔥 FAIL METADATA.pb: Fullname "Noto Serif TC" does not match name table entry "Noto Serif TC ExtraLight"! [code: fullname-mismatch]
🔥 FAIL: METADATA.pb: Check URL on copyright string is the same as in repository_url field. (com.google.fonts/check/metadata/consistent_repo_urls)
  • 🔥 FAIL Value of repository_url field is

But font copyright string has: http://www.adobe.com/
[code: mismatch]

🔥 FAIL: Check samples can be rendered. (com.google.fonts/check/metadata/can_render_samples)
  • 🔥 FAIL Font can't render "yue_Hant" sample text:
    "鉴于对人权嘅无视同埋侮蔑经已发展成为野蛮暴行,呢些暴行玷污咗人类嘅良心,而一个人人都有言论同埋信仰自由而且冇惊冇穷嘅世界嘅嚟临"
    [code: sample-text]
  • WARN Aparently there's no sample strings for 'cjy_Hant' in the gflanguages package. [code: no-sample-string]
  • WARN Aparently there's no sample strings for 'gan_Hant' in the gflanguages package. [code: no-sample-string]
  • WARN Aparently there's no sample strings for 'hsn_Hant' in the gflanguages package. [code: no-sample-string]
  • WARN Aparently there's no sample strings for 'wuu_Hant' in the gflanguages package. [code: no-sample-string]
🔥 FAIL: Ensure dotted circle glyph is present and can attach marks. (com.google.fonts/check/dotted_circle)
  • 🔥 FAIL The following glyphs could not be attached to the dotted circle glyph:

    • acutecomb

    • gravecomb

    • uni0307

    • uni030C [code: unattached-dotted-circle-marks]

WARN: Check for codepoints not covered by METADATA subsets. (com.google.fonts/check/metadata/unreachable_subsetting)
  • WARN The following codepoints supported by the font are not covered by
    any subsets defined in the font's metadata file, and will never
    be served. You can solve this by either manually adding additional
    subset declarations to METADATA.pb, or by editing the glyphset
    definitions.

  • U+02C7 CARON: try adding one of: yi, canadian-aboriginal, tifinagh

  • U+02D9 DOT ABOVE: try adding one of: yi, canadian-aboriginal

  • U+0307 COMBINING DOT ABOVE: try adding one of: tai-le, malayalam, canadian-aboriginal, coptic, old-permic, math, syriac, tifinagh

  • U+030C COMBINING CARON: try adding one of: tai-le, cherokee

  • U+0391 GREEK CAPITAL LETTER ALPHA: try adding one of: greek, elbasan, math

  • U+0392 GREEK CAPITAL LETTER BETA: try adding one of: greek, elbasan, math

  • U+0393 GREEK CAPITAL LETTER GAMMA: try adding one of: greek, elbasan, math

  • U+0394 GREEK CAPITAL LETTER DELTA: try adding one of: greek, elbasan, math

  • U+0395 GREEK CAPITAL LETTER EPSILON: try adding one of: greek, elbasan, math

  • U+0396 GREEK CAPITAL LETTER ZETA: try adding one of: greek, elbasan, math
    3606 more.

Use -F or --full-lists to disable shortening of long lists.

Or you can add the above codepoints to one of the subsets supported by the font: chinese-traditional, cyrillic, latin, latin-ext, menu, vietnamese [code: unreachable-subsetting]

WARN: License URL matches License text on name table? (com.google.fonts/check/name/license_url)
  • WARN Please consider using HTTPS URLs at name table entry [plat=3, enc=1, name=14] [code: http-in-license-info]
WARN: Are there caret positions declared for every ligature? (com.google.fonts/check/ligature_carets)
  • WARN This font lacks caret position values for ligature glyphs on its GDEF table. [code: lacks-caret-pos]
WARN: Is there kerning info for non-ligated sequences? (com.google.fonts/check/kerning_for_non_ligated_sequences)
  • WARN GPOS table lacks kerning info for the following non-ligated sequences:

    • f + f

    • f + i

    • i + f

    • f + l

    • l + f

    • i + l [code: lacks-kern-info]

WARN: Combined length of family and style must not exceed 27 characters. (com.google.fonts/check/name/family_and_style_max_length)
  • WARN The combined length of family and style exceeds 27 chars in the following 'WINDOWS' entries:
    FONT_FAMILY_NAME = 'Noto Serif TC ExtraLight' / SUBFAMILY_NAME = 'Regular'

Please take a look at the conversation at fonttools/fontbakery#2179 in order to understand the reasoning behind these name table records max-length criteria. [code: too-long]

WARN: A static fonts directory with at least two fonts must accompany variable fonts (com.google.fonts/check/repo/vf_has_static_fonts)
  • WARN Please consider adding a subdirectory called "static/" and including in it static font files. [code: missing]
WARN: Ensure fonts have ScriptLangTags declared on the 'meta' table. (com.google.fonts/check/meta/script_lang_tags)
  • WARN This font file does not have a 'meta' table. [code: lacks-meta-table]
WARN: Check font contains no unreachable glyphs (com.google.fonts/check/unreachable_glyphs)
  • WARN The following glyphs could not be reached by codepoint or substitution rules:

    • glyph00470

    • glyph00472

    • glyph00473

    • glyph00477

    • glyph00603

    • glyph01006

    • glyph01112

    • glyph01134

    • glyph01668

    • glyph01670

    • 96 more.

Use -F or --full-lists to disable shortening of long lists.
[code: unreachable-glyphs]

WARN: Does the font contain a soft hyphen? (com.google.fonts/check/soft_hyphen)
  • WARN This font has a 'Soft Hyphen' character. [code: softhyphen]
WARN: Does the font contain chws and vchw features? (com.google.fonts/check/cjk_chws_feature)
WARN: Check math signs have the same width. (com.google.fonts/check/math_signs_width)
  • WARN The most common width is 1000 among a set of 43 math glyphs.
    The following math glyphs have a different width, though:

Width = 571:
less, minus, equal, greater, logicalnot, plus
[code: width-outliers]

WARN: Font has correct post table version? (com.google.fonts/check/post_table_version)
  • WARN Post table format 3 use has niche use case problems.Please review the check rationale for additional details. [code: post-table-version]
WARN: Check mark characters are in GDEF mark glyph class. (com.google.fonts/check/gdef_mark_chars)
  • WARN The following mark characters could be in the GDEF mark glyph class:
    uni0304 (U+0304), uni20DD (U+20DD), uni20DE (U+20DE), uni302A (U+302A), uni302B (U+302B), uni302C (U+302C), uni302D (U+302D), uni3099 (U+3099) and uni309A (U+309A) [code: mark-chars]
INFO: Show hinting filesize impact. (com.google.fonts/check/hinting_impact)
  • INFO Hinting filesize impact:
ofl/notoseriftc/NotoSerifTC[wght].ttf
Dehinted Size 16.1Mb
Hinted Size 16.1Mb
Increase 24 bytes
Change 0.0 %
[code: size-impact]
INFO: Font has old ttfautohint applied? (com.google.fonts/check/old_ttfautohint)
  • INFO Could not detect which version of ttfautohint was used in this font. It is typically specified as a comment in the font version entries of the 'name' table. Such font version strings are currently: ['Version 2.002-H1;hotconv 1.1.0;makeotfexe 2.6.0'] [code: version-not-detected]
INFO: EPAR table present in font? (com.google.fonts/check/epar)
INFO: Is the Grid-fitting and Scan-conversion Procedure ('gasp') table set to optimize rendering? (com.google.fonts/check/gasp)
  • INFO These are the ppm ranges declared on the gasp table:

PPM <= 65535:
flag = 0x0F
- Use grid-fitting
- Use grayscale rendering
- Use gridfitting with ClearType symmetric smoothing
- Use smoothing along multiple axes with ClearType®
[code: ranges]

INFO: Check for font-v versioning. (com.google.fonts/check/fontv)
  • INFO Version string is: "Version 2.002-H1;hotconv 1.1.0;makeotfexe 2.6.0"
    The version string must ideally include a git commit hash and either a "dev" or a "release" suffix such as in the example below:
    "Version 1.3; git-0d08353-release" [code: bad-format]
INFO: Font contains all required tables? (com.google.fonts/check/required_tables)
  • INFO This font contains the following optional tables:

    • loca

    • prep

    • BASE

    • GPOS

    • GSUB

    • gasp

    • vhea

    • vmtx [code: optional-tables]

INFO: List all superfamily filepaths (com.google.fonts/check/superfamily/list)
  • INFO ofl/notoseriftc [code: family-path]

Summary

💔 ERROR 🔥 FAIL ⚠ WARN 💤 SKIP ℹ INFO 🍞 PASS 🔎 DEBUG
0 14 13 51 8 163 0
0% 6% 5% 20% 3% 65% 0%

Note: The following loglevels were omitted in this report:

  • SKIP
  • PASS
  • DEBUG

@m4rc1e
Copy link
Collaborator

m4rc1e commented Sep 12, 2023

@simoncozens I've just cut a new release of diff2 which includes your latest commits. Hopefully these prs should now work.

@github-actions
Copy link

FontBakery report

fontbakery version: 0.9.0

[1] Family checks
INFO: Check axis ordering on the STAT table. (com.google.fonts/check/STAT/axis_order)
  • INFO From a total of 1 font files, 0 of them (0.00%) lack a STAT table.

    And these are the most common STAT axis orderings:
    ('wght', 1) [code: summary]


[30] NotoSerifTC[wght].ttf
🔥 FAIL: Check Google Fonts glyph coverage. (com.google.fonts/check/glyph_coverage)
  • 🔥 FAIL Missing required codepoints:

    • 0x0308 (COMBINING DIAERESIS)

    • 0x030B (COMBINING DOUBLE ACUTE ACCENT)

    • 0x0104 (LATIN CAPITAL LETTER A WITH OGONEK)

    • 0x0106 (LATIN CAPITAL LETTER C WITH ACUTE)

    • 0x010C (LATIN CAPITAL LETTER C WITH CARON)

    • 0x010A (LATIN CAPITAL LETTER C WITH DOT ABOVE)

    • 0x010E (LATIN CAPITAL LETTER D WITH CARON)

    • 0x0116 (LATIN CAPITAL LETTER E WITH DOT ABOVE)

    • 0x0118 (LATIN CAPITAL LETTER E WITH OGONEK)

    • 0x011E (LATIN CAPITAL LETTER G WITH BREVE)

    • 93 more.

Use -F or --full-lists to disable shortening of long lists. [code: missing-codepoints]

🔥 FAIL: Check license file has good copyright string. (com.google.fonts/check/license/OFL_copyright)
  • 🔥 FAIL First line in license file is:

"copyright 2012 google inc. all rights reserved."

which does not match the expected format, similar to:

"Copyright 2022 The Familyname Project Authors (git url)" [code: bad-format]

🔥 FAIL: Check OFL body text is correct. (com.google.fonts/check/license/OFL_body_text)
🔥 FAIL: Ensure files are not too large. (com.google.fonts/check/file_size)
  • 🔥 FAIL Font file is 16.1Mb, larger than limit 9.0Mb [code: massive-font]
🔥 FAIL: METADATA.pb font.name field contains font name in right format? (com.google.fonts/check/metadata/valid_name_values)
  • 🔥 FAIL METADATA.pb font.name field ("Noto Serif TC") does not match correct font name format ("Noto Serif TC ExtraLight"). [code: mismatch]
🔥 FAIL: Copyright notices match canonical pattern in METADATA.pb (com.google.fonts/check/metadata/valid_copyright)
  • 🔥 FAIL METADATA.pb: Copyright notices should match a pattern similar to:
    "Copyright 2020 The Familyname Project Authors (git url)"
    But instead we have got:
    "(c) 2017-2023 adobe (http://www.adobe.com/)." [code: bad-notice-format]
🔥 FAIL: Copyright notices match canonical pattern in fonts (com.google.fonts/check/font_copyright)
  • 🔥 FAIL Name Table entry: Copyright notices should match a pattern similar to: "Copyright 2019 The Familyname Project Authors (git url)"
    But instead we have got:
    "(c) 2017-2023 Adobe (http://www.adobe.com/)." [code: bad-notice-format]
🔥 FAIL: METADATA.pb: Check URL on copyright string is the same as in repository_url field. (com.google.fonts/check/metadata/consistent_repo_urls)
  • 🔥 FAIL Value of repository_url field is

But font copyright string has: http://www.adobe.com/
[code: mismatch]

🔥 FAIL: Check samples can be rendered. (com.google.fonts/check/metadata/can_render_samples)
  • 🔥 FAIL Font can't render "yue_Hant" sample text:
    "鉴于对人权嘅无视同埋侮蔑经已发展成为野蛮暴行,呢些暴行玷污咗人类嘅良心,而一个人人都有言论同埋信仰自由而且冇惊冇穷嘅世界嘅嚟临"
    [code: sample-text]
  • WARN Aparently there's no sample strings for 'cjy_Hant' in the gflanguages package. [code: no-sample-string]
  • WARN Aparently there's no sample strings for 'gan_Hant' in the gflanguages package. [code: no-sample-string]
  • WARN Aparently there's no sample strings for 'hsn_Hant' in the gflanguages package. [code: no-sample-string]
  • WARN Aparently there's no sample strings for 'wuu_Hant' in the gflanguages package. [code: no-sample-string]
🔥 FAIL: Ensure dotted circle glyph is present and can attach marks. (com.google.fonts/check/dotted_circle)
  • 🔥 FAIL The following glyphs could not be attached to the dotted circle glyph:

    • acutecomb

    • gravecomb

    • uni0307

    • uni030C [code: unattached-dotted-circle-marks]

WARN: Check for codepoints not covered by METADATA subsets. (com.google.fonts/check/metadata/unreachable_subsetting)
  • WARN The following codepoints supported by the font are not covered by
    any subsets defined in the font's metadata file, and will never
    be served. You can solve this by either manually adding additional
    subset declarations to METADATA.pb, or by editing the glyphset
    definitions.

  • U+02C7 CARON: try adding one of: yi, canadian-aboriginal, tifinagh

  • U+02D9 DOT ABOVE: try adding one of: yi, canadian-aboriginal

  • U+0307 COMBINING DOT ABOVE: try adding one of: tifinagh, math, canadian-aboriginal, tai-le, coptic, syriac, old-permic, malayalam

  • U+030C COMBINING CARON: try adding one of: cherokee, tai-le

  • U+0391 GREEK CAPITAL LETTER ALPHA: try adding one of: math, greek, elbasan

  • U+0392 GREEK CAPITAL LETTER BETA: try adding one of: math, greek, elbasan

  • U+0393 GREEK CAPITAL LETTER GAMMA: try adding one of: math, greek, elbasan

  • U+0394 GREEK CAPITAL LETTER DELTA: try adding one of: math, greek, elbasan

  • U+0395 GREEK CAPITAL LETTER EPSILON: try adding one of: math, greek, elbasan

  • U+0396 GREEK CAPITAL LETTER ZETA: try adding one of: math, greek, elbasan
    3606 more.

Use -F or --full-lists to disable shortening of long lists.

Or you can add the above codepoints to one of the subsets supported by the font: chinese-traditional, cyrillic, latin, latin-ext, menu, vietnamese [code: unreachable-subsetting]

WARN: License URL matches License text on name table? (com.google.fonts/check/name/license_url)
  • WARN Please consider using HTTPS URLs at name table entry [plat=3, enc=1, name=14] [code: http-in-license-info]
WARN: Are there caret positions declared for every ligature? (com.google.fonts/check/ligature_carets)
  • WARN This font lacks caret position values for ligature glyphs on its GDEF table. [code: lacks-caret-pos]
WARN: Is there kerning info for non-ligated sequences? (com.google.fonts/check/kerning_for_non_ligated_sequences)
  • WARN GPOS table lacks kerning info for the following non-ligated sequences:

    • f + f

    • f + i

    • i + f

    • f + l

    • l + f

    • i + l [code: lacks-kern-info]

WARN: Combined length of family and style must not exceed 27 characters. (com.google.fonts/check/name/family_and_style_max_length)
  • WARN The combined length of family and style exceeds 27 chars in the following 'WINDOWS' entries:
    FONT_FAMILY_NAME = 'Noto Serif TC ExtraLight' / SUBFAMILY_NAME = 'Regular'

Please take a look at the conversation at fonttools/fontbakery#2179 in order to understand the reasoning behind these name table records max-length criteria. [code: too-long]

WARN: A static fonts directory with at least two fonts must accompany variable fonts (com.google.fonts/check/repo/vf_has_static_fonts)
  • WARN Please consider adding a subdirectory called "static/" and including in it static font files. [code: missing]
WARN: Ensure fonts have ScriptLangTags declared on the 'meta' table. (com.google.fonts/check/meta/script_lang_tags)
  • WARN This font file does not have a 'meta' table. [code: lacks-meta-table]
WARN: Check font contains no unreachable glyphs (com.google.fonts/check/unreachable_glyphs)
  • WARN The following glyphs could not be reached by codepoint or substitution rules:

    • glyph00470

    • glyph00472

    • glyph00473

    • glyph00477

    • glyph00603

    • glyph01006

    • glyph01112

    • glyph01134

    • glyph01668

    • glyph01670

    • 96 more.

Use -F or --full-lists to disable shortening of long lists.
[code: unreachable-glyphs]

WARN: Does the font contain a soft hyphen? (com.google.fonts/check/soft_hyphen)
  • WARN This font has a 'Soft Hyphen' character. [code: softhyphen]
WARN: Does the font contain chws and vchw features? (com.google.fonts/check/cjk_chws_feature)
WARN: Check math signs have the same width. (com.google.fonts/check/math_signs_width)
  • WARN The most common width is 1000 among a set of 43 math glyphs.
    The following math glyphs have a different width, though:

Width = 571:
greater, less, plus, minus, logicalnot, equal
[code: width-outliers]

WARN: Font has correct post table version? (com.google.fonts/check/post_table_version)
  • WARN Post table format 3 use has niche use case problems.Please review the check rationale for additional details. [code: post-table-version]
WARN: Check mark characters are in GDEF mark glyph class. (com.google.fonts/check/gdef_mark_chars)
  • WARN The following mark characters could be in the GDEF mark glyph class:
    uni0304 (U+0304), uni20DD (U+20DD), uni20DE (U+20DE), uni302A (U+302A), uni302B (U+302B), uni302C (U+302C), uni302D (U+302D), uni3099 (U+3099) and uni309A (U+309A) [code: mark-chars]
INFO: Show hinting filesize impact. (com.google.fonts/check/hinting_impact)
  • INFO Hinting filesize impact:
ofl/notoseriftc/NotoSerifTC[wght].ttf
Dehinted Size 16.1Mb
Hinted Size 16.1Mb
Increase 24 bytes
Change 0.0 %
[code: size-impact]
INFO: Font has old ttfautohint applied? (com.google.fonts/check/old_ttfautohint)
  • INFO Could not detect which version of ttfautohint was used in this font. It is typically specified as a comment in the font version entries of the 'name' table. Such font version strings are currently: ['Version 2.002-H1;hotconv 1.1.0;makeotfexe 2.6.0'] [code: version-not-detected]
INFO: EPAR table present in font? (com.google.fonts/check/epar)
INFO: Is the Grid-fitting and Scan-conversion Procedure ('gasp') table set to optimize rendering? (com.google.fonts/check/gasp)
  • INFO These are the ppm ranges declared on the gasp table:

PPM <= 65535:
flag = 0x0F
- Use grid-fitting
- Use grayscale rendering
- Use gridfitting with ClearType symmetric smoothing
- Use smoothing along multiple axes with ClearType®
[code: ranges]

INFO: Check for font-v versioning. (com.google.fonts/check/fontv)
  • INFO Version string is: "Version 2.002-H1;hotconv 1.1.0;makeotfexe 2.6.0"
    The version string must ideally include a git commit hash and either a "dev" or a "release" suffix such as in the example below:
    "Version 1.3; git-0d08353-release" [code: bad-format]
INFO: Font contains all required tables? (com.google.fonts/check/required_tables)
  • INFO This font contains the following optional tables:

    • loca

    • prep

    • BASE

    • GPOS

    • GSUB

    • gasp

    • vhea

    • vmtx [code: optional-tables]

INFO: List all superfamily filepaths (com.google.fonts/check/superfamily/list)
  • INFO ofl/notoseriftc [code: family-path]

Summary

💔 ERROR 🔥 FAIL ⚠ WARN 💤 SKIP ℹ INFO 🍞 PASS 🔎 DEBUG
0 10 13 51 8 168 0
0% 4% 5% 20% 3% 67% 0%

Note: The following loglevels were omitted in this report:

  • SKIP
  • PASS
  • DEBUG

@RosaWagner RosaWagner merged commit 525797b into main Sep 14, 2023
9 checks passed
@RosaWagner RosaWagner deleted the notoseriftc-2.002-H1 branch September 14, 2023 15:45
@chrissimpkins
Copy link
Collaborator

chrissimpkins commented Sep 18, 2023

I believe that we need CJK subsetter definition updates to onboard the latest Noto Serif CJK family releases that address the GB18030-2022 revision. @simoncozens mind looking into this?

@RosaWagner @eliheuer

@RosaWagner RosaWagner added the -- Needs lang/glyphset update Missing glyphs in .nam or sample text (not a font issue) label Sep 21, 2023
@emmamarichal emmamarichal mentioned this pull request Feb 2, 2024
29 tasks
@emmamarichal emmamarichal removed the -- Needs lang/glyphset update Missing glyphs in .nam or sample text (not a font issue) label Mar 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
I Font Upgrade II CJK Chinese, Japanese, Korean scripts
Projects
Status: Live
Development

Successfully merging this pull request may close these issues.

Update Noto Serif CJK to address the GB18030-2022 revision
5 participants