Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(siren): add hard check on child receiver type creation #16

Merged
merged 1 commit into from
Aug 2, 2023
Merged

feat(siren): add hard check on child receiver type creation #16

merged 1 commit into from
Aug 2, 2023

Conversation

mabdh
Copy link
Member

@mabdh mabdh commented Aug 2, 2023

No description provided.

@coveralls
Copy link

coveralls commented Aug 2, 2023 •
edited
Loading

Pull Request Test Coverage Report for Build 5736253254

  • 18 of 21 (85.71%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.04%) to 77.108%
Changes Missing Coverage Covered Lines Changed/Added Lines %
core/receiver/service.go 16 19 84.21%
Totals Coverage Status
Change from base Build 5734717119: 0.04%
Covered Lines: 3584
Relevant Lines: 4648
💛 - Coveralls

StewartJingga
StewartJingga approved these changes Aug 2, 2023
View reviewed changes
Copy link

@StewartJingga StewartJingga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mabdh mabdh merged commit 7682e54 into main Aug 2, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@StewartJingga StewartJingga StewartJingga approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mabdh @coveralls @StewartJingga