Use challenge response when adding MFA device #47593
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avatus
added
the
no-changelog
Joerger
approved these changes
Oct 15, 2024
|
@avatus We can backport this to v16/v15 as well, there are some edge cases unreleated to SSO MFA that this covers. |
|
@bl-nero please take a look at this one when you get the chance 🙏 |
flyinghermit
approved these changes
Oct 16, 2024
bl-nero
approved these changes
Oct 16, 2024
| @@ -258,6 +258,21 @@ const auth = { | |||
| return api.post(cfg.api.createPrivilegeTokenPath, { secondFactorToken }); | |||
| }, | |||
|
|
|||
| async getChallenge( | |||
| req: CreateAuthenticateChallengeRequest, | |||
| abortSignal?: AbortSignal | |||
There was a problem hiding this comment.
I don't see us using the abort signal anywhere. Consider removing it.
ryanclark
approved these changes
Oct 17, 2024
This PR changes the requirement for the "Reauthenticate" step when adding an MFA device. Currently, we rely on the number of devices returned when we fetch the devices. However, in the future with SSOasMFA, these devices won't always be enabled. This will allow us to check the backend if any of the available devices are "enabled" and if we've received a valid challenge for a device. if not, we forward the user through the privilege token flow instead. This will be expanded by checking for SSO challenges as well and can now be expanded for any other type of auth.
This was referenced Oct 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of SSO as MFA
This PR changes the requirement for the "Reauthenticate" step when adding an MFA device. Currently, we rely on the number of devices returned when we fetch the devices. However, in the future with SSOasMFA, these devices won't always be enabled.
This will allow us to check the backend if any of the available devices are "enabled" and if we've received a valid challenge for a device. if not, we forward the user through the privilege token flow instead.
This will be expanded by checking for SSO challenges as well and can now be expanded for any other type of auth.
@Joerger you can determine when/where we will need backports for this and let me know. Thank you!