Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use challenge response when adding MFA device #47593

Merged
merged 1 commit into from
Oct 17, 2024
Merged

Use challenge response when adding MFA device #47593

merged 1 commit into from
Oct 17, 2024
+35 −6

Commits on Oct 17, 2024

  1. Use challenge response when adding MFA device 

    This PR changes the requirement for the "Reauthenticate" step when
adding an MFA device. Currently, we rely on the number of devices
returned when we fetch the devices. However, in the future with
SSOasMFA, these devices won't always be enabled.

This will allow us to check the backend if any of the available devices
are "enabled" and if we've received a valid challenge for a device. if
not, we forward the user through the privilege token flow instead.

This will be expanded by checking for SSO challenges as well and can now
be expanded for any other type of auth.
    @avatus
    avatus committed Oct 17, 2024
    Configuration menu
    Copy the full SHA
    3f2b160 View commit details
    Browse the repository at this point in the history