-
-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(external-router)!: rework to use canMatchFn #2907
Open
damienwebdev
wants to merge
7
commits into
develop
Choose a base branch
from
fix_external_router
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
damienwebdev
force-pushed
the
fix_external_router
branch
2 times, most recently
from
October 18, 2024 14:30
c6b41dc
to
23f51f0
Compare
damienwebdev
changed the title
feat!(external-router): rework
feat(external-router)!: rework to use canMatchFn
Oct 18, 2024
damienwebdev
force-pushed
the
fix_external_router
branch
from
October 18, 2024 17:24
23f51f0
to
93b0f39
Compare
BREAKING CHANGE: This is a substantial overhaul to the `@daffodil/external-router`. The most important change is the removal of `DaffExternalRouterExistenceGuard` and supporting services in favor of `daffExternalMatcherTypeGuard`. See the docs for exactly how to change your `Routes`. Additionally, all tokens have been documented along with new guides for the drivers. Finally, `daffSeoData` is also available on matched routes. This can be used for adjusting titles and schema data.
griest024
requested changes
Oct 20, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I love this! So much better
libs/external-router/routing/src/guard/external-matcher-type.guard.ts
Outdated
Show resolved
Hide resolved
libs/external-router/routing/src/guard/external-matcher-type.guard.ts
Outdated
Show resolved
Hide resolved
damienwebdev
force-pushed
the
fix_external_router
branch
from
October 21, 2024 14:32
93b0f39
to
e1e50e5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
Fixes: #1855
Fixes: #1672
What is the current behavior?
Currently, developers have to use
DaffExternalRouterExistenceGuard
which requires:when navigating to any route that requires use of this guard alongside
daffPath
data.What is the new behavior?
The new behavior leverages the
canMatch
guards created in Angular 14. You can configure routes as follows (without any complex looking configuration):Which is much more syntactically direct. It also fixes the original issue as the debug log looks like:
Does this PR introduce a breaking change?
Users should:
in favor of
Route
configuration from:to:
Other information