Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

First Property Permissions #812

Open
wants to merge 33 commits into
base: main
Choose a base branch
from
Open

First Property Permissions #812

wants to merge 33 commits into from

Conversation

FoseFx
Copy link
Member

@FoseFx FoseFx commented Sep 11, 2024 •
edited
Loading

  • moves spice.go into cmd/spice
  • moves parts of spice.go to hwauthz
  • add spicedb to stories tests
  • fix testcontainers eventstore issue, which prevented usage of modules
  • rename teams to organizations (technically breaking, but never used)
  • permissive permissions for CRU(D) of properties
  • integration of those into property-svc
  • add index as a first parameter to hwutil.Filter

@FoseFx FoseFx marked this pull request as ready for review September 12, 2024 15:02
@FoseFx FoseFx requested a review from a team as a code owner September 12, 2024 15:02
@FoseFx FoseFx requested review from PaulKalho, Paul-B98 and MaxSchaefer and removed request for a team September 12, 2024 15:02
@FoseFx FoseFx self-assigned this Sep 13, 2024
@FoseFx FoseFx mentioned this pull request Sep 13, 2024
Merged
@FoseFx FoseFx added blocker is-blocked This gets blocked. Check out "Blocked by #xyz" comments. and removed blocker labels Sep 13, 2024
@FoseFx FoseFx removed the is-blocked This gets blocked. Check out "Blocked by #xyz" comments. label Oct 17, 2024
@FoseFx FoseFx marked this pull request as draft October 17, 2024 15:17
@FoseFx FoseFx marked this pull request as ready for review October 19, 2024 23:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PaulKalho PaulKalho Awaiting requested review from PaulKalho PaulKalho is a code owner automatically assigned from helpwave/backend

@Paul-B98 Paul-B98 Awaiting requested review from Paul-B98 Paul-B98 is a code owner automatically assigned from helpwave/backend

@MaxSchaefer MaxSchaefer Awaiting requested review from MaxSchaefer

At least 1 approving review is required to merge this pull request.

Assignees

@FoseFx FoseFx

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@FoseFx