New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(contracts): minor token related changes #4580

Open

aroralanuk wants to merge 3 commits into main from kunal/token-minor-audit

+117 −23

Open

fix(contracts): minor token related changes #4580

gas router event

GitHub Advanced Security / Olympix Integrated Security failed Sep 26, 2024 in 8s

2 new alerts including 1 critical severity security vulnerability

New alerts in code changed by this pull request

Security Alerts:

1 critical
1 low

See annotations below for details.

View all branch alerts.

Annotations

Check failure on line 136 in solidity/test/token/HypERC4626Test.t.sol

Code scanning / Olympix Integrated Security

Modifying state after making an external call may allow for reentrancy attacks. For more information, visit: http://detectors.olympixdevsectools.com/article/web3-vulnerability/reentrancy Critical test

Modifying state after making an external call may allow for reentrancy attacks. For more information, visit: http://detectors.olympixdevsectools.com/article/web3-vulnerability/reentrancy

Check notice on line 136 in solidity/test/token/HypERC4626Test.t.sol

Code scanning / Olympix Integrated Security

Reentrant functions which emit events after making an external call may lead to out-of-order events. For more information, visit: http://detectors.olympixdevsectools.com/article/web3-vulnerability/reentrancy-events Low test

Reentrant functions which emit events after making an external call may lead to out-of-order events. For more information, visit: http://detectors.olympixdevsectools.com/article/web3-vulnerability/reentrancy-events