Refactor for better maintainability #142
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To make top 100 feature PRs more organized
|
Clarify if this PR is tested with some of the 5 + 7 testing scenarios at... ? (Which if so? Thanks!) |
|
Tested with a short playlist for shelf creation and population (1 and 6)
|
deldesir
added a commit
to deldesir/calibre-web
that referenced
this pull request
Mar 27, 2024
This builds upon iiab#142 to progress towards implementing the top 100 feature
Do you mean the NEW Testing Scenarios 1 and 6 at... ? (And if so, are the OLDER Testing Scenarios 1-to-5 at the top of #79 sufficiently tested/safe here?) |
|
Yes, I mean the new testing scenarios. I smoke tested this PR for existing functionalities, so the older ones scenarios still apply and are guaranteed to work as expected. No regression were introduced, no feature were added. I've been working on it for hours. However, if something is missed or broken, it will be addressed promptly. |
deldesir
added a commit
to deldesir/calibre-web
that referenced
this pull request
Mar 27, 2024
This builds upon iiab#142 to progress towards implementing the top 100 feature
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this PR, the metadata task code is better structured. There is no functionality added, just a refactor. This will allow top 100 feature PRs to be more organized.