Fix the lint issues #39
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kd7lxl
reviewed
Oct 14, 2024
ramya-bangera
force-pushed
the
fixUtLintErr
branch
from
d26ddea
to
bf8309c
Compare
kd7lxl
approved these changes
Oct 15, 2024
1. fix errcheck in main.go - check return value of `viper.BindPFlags` 2. fix v in config.go - added nolint to config.go to escape from lint issues as it contains unused variables. This file can even be removed from repo if not needed
ramya-bangera
force-pushed
the
fixUtLintErr
branch
from
bf8309c
to
0891ef0
Compare
ramya-bangera
changed the title
Newer versions of postgres require a password
… issues. See: https://docs.docker.com/engine/deprecated/#pushing-and-pulling-with-image-manifest-v2-schema-1 Forked images created by pulling the original image and pushing to the fork. For more details, see: golang-migrate#1143 (comment)
|
Closing as this requires a full merge from upstream |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
viper.BindPFlags