Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the lint issues #39

Closed
wants to merge 4 commits into from

Commits on Oct 17, 2024

  1. Fix the lint issues

    1. fix errcheck in main.go - check return value of `viper.BindPFlags`
    2. fix v in config.go - added nolint to config.go to escape from lint issues as it contains unused variables. This file can even be removed from repo if not needed
    ramya-bangera committed Oct 17, 2024
    Configuration menu
    Copy the full SHA
    0891ef0 View commit details
    Browse the repository at this point in the history
  2. Fix redshift tests

    Newer versions of postgres require a password
    dhui authored and ramya-bangera committed Oct 17, 2024
    Configuration menu
    Copy the full SHA
    e1e3a42 View commit details
    Browse the repository at this point in the history
  3. Use forked version of postgres 8 to avoid Docker image format version…

    … issues.
    
    See: https://docs.docker.com/engine/deprecated/#pushing-and-pulling-with-image-manifest-v2-schema-1
    
    Forked images created by pulling the original image and pushing to the fork. For more details, see: golang-migrate#1143 (comment)
    dhui authored and ramya-bangera committed Oct 17, 2024
    Configuration menu
    Copy the full SHA
    0e8dc7c View commit details
    Browse the repository at this point in the history
  4. Use newer math/rand/v2

    dhui authored and ramya-bangera committed Oct 17, 2024
    Configuration menu
    Copy the full SHA
    69bfe09 View commit details
    Browse the repository at this point in the history