Replace PlatformMapper with a function #120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using the visitor pattern to map platforms is unnecessary, since the mapping code needs to visit every CodeNode in the tree. Iterating through the list of CodeNodes is much more straightforward. This commit also removes TreeMapper, since PlatformMapper was the only class descended from it. Signed-off-by: John Pennycook <[email protected]>
laserkelvin
approved these changes
Nov 4, 2024
Pennycook
added a commit
to Pennycook/code-base-investigator
that referenced
this pull request
Nov 5, 2024
This somehow slipped through the cracks when intel#120 was merged, and wasn't identified until the CI tests ran on the merge commit. Signed-off-by: John Pennycook <[email protected]>
This was referenced Nov 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using the visitor pattern to map platforms is unnecessary, since the mapping code needs to visit every
CodeNodein the tree. Iterating through the list ofCodeNodesis much more straightforward.This commit also removes
TreeMapper, sincePlatformMapperwas the only class descended from it.Related issues
Part of #101.
Proposed changes
PlatformMapperclass with a simplerget_setmap()function.While working on this, I realized that "setmap" isn't a very good name, and doesn't really describe what it represents. But I think we should defer that bikeshedding for later.